Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

[Vincent Povirk]

> -            GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0);
> +            GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0);

You probably shouldn't use the same GpRect* for both parameters there.

[1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> > -            GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0);
> > +            GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0);
>
> You probably shouldn't use the same GpRect* for both parameters there.

I don't see any problem with that.

-- 
Dmitry.

[1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

[Vincent Povirk]

> > > +            GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0);
> >
> > You probably shouldn't use the same GpRect* for both parameters there.
>
> I don't see any problem with that.

GdipMeasureString modifies the out parameter and reads the in
parameter as it goes, and it doesn't account for the possibility that
it is modifying its own input rectangle.

[1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> > > > +            GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0);
> > >
> > > You probably shouldn't use the same GpRect* for both parameters there.
> >
> > I don't see any problem with that.
>
> GdipMeasureString modifies the out parameter and reads the in
> parameter as it goes, and it doesn't account for the possibility that
> it is modifying its own input rectangle.

My tests show that it's not a problem, but I can resend of course
with that change in order to make it less confusing.

-- 
Dmitry.