Re: dinput: Delete the static critical section when unloading the dll.
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead.
Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them? Vitaliy.
On 11/16/2011 07:34 PM, Vitaliy Margolen wrote:
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead.
Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them?
On the side note, why do we need to delete statically allocated critical section in the first place? Vitaliy.
On Wed, 16 Nov 2011, Vitaliy Margolen wrote:
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead.
I think it makes more sense to move DllMain() to the end of the file since nothing is going to need it before. But it may also make sense to move the critical section declaration up to where it is declared forward.
On the side note, why do we need to delete statically allocated critical section in the first place?
To make sure the corresponding (NT) semaphore or native locking entity gets released (futexes reportedly don't need it but maybe mach semaphores or others do). Note that there are still a lot of critical sections (static and not) that are not ever released. I only did the easy ones. -- Francois Gouget <fgouget(a)codeweavers.com>
Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead.
Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them?
I do when it's a potentially controversial change, but moving functions to avoid forward declarations is common practice. -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
Francois Gouget -
Vitaliy Margolen