Re: [PATCH 2/5] wined3d: Move location management into the resource.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

To illustrate the goal of these patches I've attached an archive of
all surface cleanup patches to this mail. The goal is to merge GL
buffer object handling of buffers, surfaces and volumes. The main
motivation for this is to handle WINED3D_MAP_DISCARD in one central
place once dynamic resource handling is implemented in the command stream.

The 4 patches in this series move location and buffer handling code
from volume.c to resource.c. The next patches remove broken(overlay,
partial rectangle handling) and half-broken(direct DIB maps, buffers)
surface features. The next step is migrating surfaces to the resource
location and loading code in resource.c. After that
WINED3D_LOCATION_DISCARDED handling is improved and previously removed
surface features re-added.

Due to the removal of some surface features, performance regressions
are possible. I think it's unlikely because the existing surface PBO
code doesn't really do what it is supposed to do. Functional
regressions should not happen.

This patchset does not deal with d3d buffers. The central aspect of
merging buffer handling is removing color and rhw conversion support.
(or, alternatively, adding a separate location
WINED3D_LOCATION_CONVBUFFER if we really want to keep the conversion
code.)

There are some problems later in the patchset that need fixing: Patch
24 is too big, patches 48 and 52 need to be moved. Non-GL ddraw
rendering is broken at the moment (black screen). My patches don't
make this any worse, but I'd like to fix it to make sure non-GL
operation works as intended.

Cheers,
Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSSqzhAAoJEN0/YqbEcdMww1wP/jYYo0B/igDHd0QwOkwk8DIz
ip4PKHxRgqaSYzswcBGZge+iBrJrvXSHh3cScG9KJ1a/VeaRlPyhDsFDzPce1VDK
0IX7iF/gKpZazPVy21lSIPQMlErSVy58fkIsd/PqKV/zyU8zNyZDkYU3n80itYrq
Y3hPhaKbJIDN8QbhIOZu0egaiHObcwomBgZCfrUv+hr+xf+gMERYbqN9gj2JWFwJ
dx4EzdeTFw1CZkFExbAJKt5zWA2KeFyitVU887WOSJpa3UbqemGpOID8vnYZlABZ
mmqrS22XWjXlo2+0s0NufxeQJHvzpkcludLkg8a12r4FDs+ORYYnGbUeUy2o2Rud
uV2quoeucA1TEAyF20JCrVNuCvDz5nvQq19rzR51k7FF/IsKGiI823ZGA54F4Dkn
DZkyDcE0rnI2Re+br1aM31ZUt/maTxQMpk10BAAjwz1jbXQ4plZ9dtO9/DObdw8r
nfPDJz+DsuBv19Th7MPjTxvXRjxVFTzlfuXNk/cOfAhgNdpEFSOGCAexGi6moSq1
6slQeLb8PqmO/83JQBuz4OI86dSoGSC6O9c/TtWXdW1PgCDyHgFvNb3jmQHsf7ya
U1o2TkkNhLvfYz5Eo85Ep8oyVIF09CDrqQzUo10q33K5Y2E3RM8Xbxc+crGtjgxA
TGwCwR8SRvAW+DfeP7bq
=MEk/
-----END PGP SIGNATURE-----