Re: comctl32: CCS_VERT flips toolbar separators' orientation

[Rob Shearman]

2009/3/17 Igor Tarasov <tarasov.igor(a)gmail.com>:
> Currently wine flips orientation of toolbar separators on
> BTNS_DROPDOWN, which is odd, since even horizontal toolbar separators
> may have this flag turned on. Tests with control spy show that native
> comctl flips orientation on CCS_VERT toolbar style, which is logical.

...
> @@ -855,7 +855,7 @@ TOOLBAR_DrawButton (HWND hwnd, TBUTTON_INFO *btnPtr, HDC hdc, DWORD dwBaseCus
>          /* empirical tests show that iBitmap can/will be non-zero    */
>          /* when drawing the vertical bar...      */
>          if ((dwStyle & TBSTYLE_FLAT) /* && (btnPtr->iBitmap == 0) */) {
> -           if (btnPtr->fsStyle & BTNS_DROPDOWN)
> +           if (dwStyle & CCS_VERT)
>                 TOOLBAR_DrawDDFlatSeparator (&rc, hdc, infoPtr);
>             else
>                 TOOLBAR_DrawFlatSeparator (&rc, hdc, infoPtr);

You should fix the name of the TOOLBAR_DrawDDFlatSeparator function
and the comments above it if you think it should be called as a result
of the CCS_VERT window style and not the BTNS_DROPDOWN button style.

-- 
Rob Shearman

comctl32: CCS_VERT flips toolbar separators' orientation

[Igor Tarasov]

> You should fix the name of the TOOLBAR_DrawDDFlatSeparator function
> and the comments above it if you think it should be called as a result
> of the CCS_VERT window style and not the BTNS_DROPDOWN button style.

I've been thinking about that. Yes, it's 100% that separators change
orientation on CCS_VERT, and not on BTNS_DROPDOWN (this style affects
only the button/separator flow). I'll rename that function and resend
the patch.

--
Igor

comctl32: CCS_VERT flips toolbar separators' orientation

[Igor Tarasov]

Well, I see that patches older and newer than the two mine were
already approved, but mine -not. Does this mean I need something more
to do?

-- 
Igor