Re: [PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.
3 Oct
2012
3 Oct
'12
8:23 a.m.
On 10/02/12 23:02, Erich E. Hoover wrote:
If a cleanup occurs because HTML Help window creation fails then list_remove() causes a crash, since the window was never added to the window list. The attached patch fixes this issue, allowing safe reloading of files (needed for part 2).
This looks like a hack. It would be better to have always valid list entry (if this really can't be added to the list earlier, you may always initialize it by list_init) or make sure to not call ReleaseHelpViewer before HHInfo is fully initialized. Jacek
4817
Age (days ago)
4817
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jacek Caban