Re: [6/6] windowscodecs: Fix 32bppGrayFloat to 8bppGray conversion.

[Dmitry Timoshkov]

Hi Vincent,

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> From: Vincent Povirk <vincent(a)codeweavers.com>
>
> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>

I'm not opposed that you're taking my patches from the staging tree, but
in this particular case it's not really clear that the bug with converting
32bppGrayFloat to 8bppGray was debugged and found by somebody else.

Adding "Spotted by ..." would be enough and appropriate, since for some
reason you didn't like the version of the patch in staging and decided to
fix the bug in a different way.

-- 
Dmitry.

[6/6] windowscodecs: Fix 32bppGrayFloat to 8bppGray conversion.

[Vincent Povirk]

Oh, I didn't think of that, sorry.

On Thu, Sep 15, 2016 at 10:06 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> Hi Vincent,
>
> Vincent Povirk <madewokherd(a)gmail.com> wrote:
> > From: Vincent Povirk <vincent(a)codeweavers.com>
> >
> > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>
>
> I'm not opposed that you're taking my patches from the staging tree, but
> in this particular case it's not really clear that the bug with converting
> 32bppGrayFloat to 8bppGray was debugged and found by somebody else.
>
> Adding "Spotted by ..." would be enough and appropriate, since for some
> reason you didn't like the version of the patch in staging and decided to
> fix the bug in a different way.
>
> --
> Dmitry.

[6/6] windowscodecs: Fix 32bppGrayFloat to 8bppGray conversion.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> Oh, I didn't think of that, sorry.

If you are going to resend the patch please consider adding an explanation
why a separate branch is required to handle the conversion.

-- 
Dmitry.