Re: [2] wineshelllink: Keep using the slash as path separator.

[Vitaliy Margolen]

Hans Leidekker wrote:
> Fixes incorrect handling of paths with dashes.

And creates invalid menu entries. Did you test this patch with
multi-level menu structure? When I tried your patch it created all menu
entries in the top level menu, with the name like:
wine-Programs-Ubi Soft-IL-2 Sturmovik Demo
Instead of being a menu:
wine
  Programs
    Ubi Soft
      IL-2 Sturmovik Demo

Last one is the way it should be but now it's 2 menus:
      IL
        2 Sturmovik Demo

Vitaliy.

[2] wineshelllink: Keep using the slash as path separator.

[Hans Leidekker]

On Thursday 08 February 2007 16:38:07 Vitaliy Margolen wrote:
> And creates invalid menu entries. Did you test this patch with
> multi-level menu structure? When I tried your patch it created all menu
> entries in the top level menu, with the name like:

Strange, I tested the patch extensively before sending it including
multilevel menu structures. It showed no differences for paths without
dashes and fixed paths with dashes for me. I just tested it again and
still produces the correct results here. I even tried /bin/bash instead
of /bin/sh but I can't reproduce what you're seeing.

Could you send me a good and a bad tarball created like this?

tar zcvf good.tar.gz \
  $HOME/.local/share/applications \
  $HOME/.local/share/desktop-directories \
  $HOME/.config/menus/applications-merged

 -Hans

[2] wineshelllink: Keep using the slash as path separator.

[Vitaliy Margolen]

Hans Leidekker wrote:
> On Thursday 08 February 2007 16:38:07 Vitaliy Margolen wrote:
> > And creates invalid menu entries. Did you test this patch with
> > multi-level menu structure? When I tried your patch it created all menu
> > entries in the top level menu, with the name like:
>
> Strange, I tested the patch extensively before sending it including
> multilevel menu structures. It showed no differences for paths without
> dashes and fixed paths with dashes for me. I just tested it again and
> still produces the correct results here. I even tried /bin/bash instead
> of /bin/sh but I can't reproduce what you're seeing.
>
> Could you send me a good and a bad tarball created like this?
>
> tar zcvf good.tar.gz \
>   $HOME/.local/share/applications \
>   $HOME/.local/share/desktop-directories \
>   $HOME/.config/menus/applications-merged
>
> -Hans
> Ok I figured it out I think. It's the older stuff that I had in there
> that was messing things up. After cleaning it up and using your patch,
> everything worked like a charm.
> So nvm - false alarm. Thanks for a good job!

Vitaliy.