Re: comctl32: Improve the stub of TaskDialogIndirect to display a simple message box pending a full implementation

[Reece Dunn]

On 20 July 2011 15:39, Jeff Latimer <lats(a)yless4u.com.au> wrote:
> This should allow more apps to run.  My mail import has blown up and I
> may have messed up the format of the patch.

The patch is line wrapped -- you need to send the patch as an
attachment in a form that gets recognised as an octet stream (using
the .patch extension should do this).
> +    if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON |
> TDCBF_NO_BUTTON | TDCBF_CANCEL_BUTTON))
> +        uType &= MB_YESNOCANCEL;
> +    else
> +    if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON |
> TDCBF_NO_BUTTON))
> +        uType &= MB_YESNO;

This will not work as intended -- (a & (b | c)) will evaluate true if
a contains either b or c, equivalent to ((a & b) || (a & c)). You need
to use ((a & b) == b) instead.

- Reece