Re: ttydrv fix (adds missing ShowWindow function)

On Thu, 22 Nov 2001, Eric Laforest wrote:
> tydrv/ttydrv.spec
> ===================================================================
> RCS file: /cvsroot/winex/wine/dlls/ttydrv/ttydrv.spec,v
> retrieving revision 1.1.1.8
> diff -r1.1.1.8 ttydrv.spec
> 71a72
> > @ cdecl ShowWindow(long long) TTYDRV_ShowWindow
> > Index: dlls/ttydrv/wnd.c
> > ===================================================================
> > RCS file: /cvsroot/winex/wine/dlls/ttydrv/wnd.c,v
> > retrieving revision 1.1.1.10
> > diff -r1.1.1.10 wnd.c
> > 648a649,809
>
> I think it is worth reading <wine>/README all the way to the end, where
> you will see:

If you add something, or fix a bug, please send a patch ('diff -u'
format preferred) to julliard(a)winehq.com or to the
wine-patches(a)winehq.com mailing list for inclusion in the next
release.

--
Alexandre Julliard
julliard(a)winehq.com


Is it asking too much to use diff -u?  Would you like to get patches
from all over the world against who knows which version of wine in
random formats?  I think -u is the only format suitable for an
open-source project.

Regards,

Lawson
---oof---

ttydrv fix (adds missing ShowWindow function)

On Thu, 22 Nov 2001 lawson_whitney(a)juno.com wrote:
> Is it asking too much to use diff -u?  Would you like to get patches
> from all over the world against who knows which version of wine in
> random formats?  I think -u is the only format suitable for an
> open-source project.
>
> Regards,

I am not the Patch Police, you don't have to hide.  I was just trying to
help, in my usual inept fashion.  Why don't you make up the patch as a
diff -u and submit it again?  Oh, please don't forget to include a
ChangeLog entry (to go eventually to <wine>/ChangeLog).

Lawson

Constants aren't, and variables won't.
---oof---