Re: [3/3] dpnet: Convert Address components to use a list

26 Feb 2015

      -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Alistair,

Alexandre made me aware that I missed a blaring issue here:

Am 2015-02-26 um 04:32 schrieb Alistair Leslie-Hughes:
...
+        temp = heap_realloc(This->components, sizeof(struct
component *) * This->comp_count+1 );
X * This->comp_count+1 won't do what you want it to do.
Also he wants the array to be grown by doubling it. If the expected
component count is low as you say, allocate the expected count at
object creation (e.g. 4), and then double the array in case you need
to grow it.

Also, in terms of style, you can write sizeof(*This->components)
instead of sizeof(struct component *). That way you won't have to
change the code if you change the type of This->components.

Stefan Dösinger

tags

participants (1)