Re: d3drm: Add tests for querying between IDirect3DRM interfaces

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-03-15 um 11:45 schrieb Aaryaman Vasishta:
> +        hr = IUnknown_QueryInterface(base_iface, tests[i].iid, (void
> **)&iface1);
> It looks like your mail client line-wrapped the patch. Unfortunately
> it won't apply this way :-( .
> +    if (!GetProcAddress(GetModuleHandleA("d3drm.dll"), "Direct3DRMCreate"))
> +    {
> +        win_skip("Direct3DRMCreate not available, skipping test.\n");
> +        return;
> +    }
> You should not need this. If Direct3DRMCreate is not available
> InitFunctionPtrs() will return false and your test is never run.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVBWQHAAoJEN0/YqbEcdMwq/IP/20pRxWk3tYXzbZmKILCNH65
JRTlm/fvqtO/Q+Q1C57WkOMiusE2w4i25/AQNsaIYOW/e8nATIGni3PPRlK6v9gT
/JzzntJLD0I4mEOBxrZvnQhQ3iZ91YMla+Sg326b3PkwONEfkWhORP4YGrkt75is
5YNCKVZG/msPT7IxUIbZji7K8McDEX/OsLLFEFDr3mg4i5z7WMxAJVBIxOGuN8re
2N2TKGfcWLEIaE5Hpyh+r9xYbS8x7JyIN5md5EdQrnBR/9KMn18VFLWX3u+4jfm3
o8uGOjhhOUqjjtzYomRe317l3ujtqjora6xNZ5upGrcxwBWSZKDB5gk233o/62W4
FJuHGeHnCaUgctBUYQstFHr9FsBFt3KkgFqhds3nnSz4MF3/I46+X7KprCiAIaMZ
q/YNasm8lGGAdNZp5DkViq9K06umOG7iz+21XY+dP9hRrTVqq11eEqEmveqRHU2+
GuOiNcKeo45Sj+4yl+r78fD3JNN2Ltki3O/z/KVjfE2aE+e5cHKn1oGAEFUaGzDl
zHd2KcI6W6e6eDy3qgo8TezfiQYogQzTriyVd9Kyxi9CxKAVnZOrskKoFj2tT3M4
PEn2qX13OtcBcIaO83QJdHtwxg1g3yQ771uIPK0MHU1zjSHAz2sHf+amn6/gF8N+
MT9amN40cQrxGXpaplzm
=d/6Z
-----END PGP SIGNATURE-----

d3drm: Add tests for querying between IDirect3DRM interfaces

[Aaryaman Vasishta]

I sent another patch fixing the line wraps and factoring the suggested
changes.

jam

On Sun, Mar 15, 2015 at 4:20 PM, Stefan Dösinger <stefandoesinger(a)gmail.com>
wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2015-03-15 um 11:45 schrieb Aaryaman Vasishta:
> > +        hr = IUnknown_QueryInterface(base_iface, tests[i].iid, (void
> > **)&iface1);
> > It looks like your mail client line-wrapped the patch. Unfortunately
> > it won't apply this way :-( .
> > +    if (!GetProcAddress(GetModuleHandleA("d3drm.dll"),
> > "Direct3DRMCreate"))
> > +    {
> > +        win_skip("Direct3DRMCreate not available, skipping test.\n");
> > +        return;
> > +    }
> > You should not need this. If Direct3DRMCreate is not available
> > InitFunctionPtrs() will return false and your test is never run.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBAgAGBQJVBWQHAAoJEN0/YqbEcdMwq/IP/20pRxWk3tYXzbZmKILCNH65
> JRTlm/fvqtO/Q+Q1C57WkOMiusE2w4i25/AQNsaIYOW/e8nATIGni3PPRlK6v9gT
> /JzzntJLD0I4mEOBxrZvnQhQ3iZ91YMla+Sg326b3PkwONEfkWhORP4YGrkt75is
> 5YNCKVZG/msPT7IxUIbZji7K8McDEX/OsLLFEFDr3mg4i5z7WMxAJVBIxOGuN8re
> 2N2TKGfcWLEIaE5Hpyh+r9xYbS8x7JyIN5md5EdQrnBR/9KMn18VFLWX3u+4jfm3
> o8uGOjhhOUqjjtzYomRe317l3ujtqjora6xNZ5upGrcxwBWSZKDB5gk233o/62W4
> FJuHGeHnCaUgctBUYQstFHr9FsBFt3KkgFqhds3nnSz4MF3/I46+X7KprCiAIaMZ
> q/YNasm8lGGAdNZp5DkViq9K06umOG7iz+21XY+dP9hRrTVqq11eEqEmveqRHU2+
> GuOiNcKeo45Sj+4yl+r78fD3JNN2Ltki3O/z/KVjfE2aE+e5cHKn1oGAEFUaGzDl
> zHd2KcI6W6e6eDy3qgo8TezfiQYogQzTriyVd9Kyxi9CxKAVnZOrskKoFj2tT3M4
> PEn2qX13OtcBcIaO83QJdHtwxg1g3yQ771uIPK0MHU1zjSHAz2sHf+amn6/gF8N+
> MT9amN40cQrxGXpaplzm
> =d/6Z
> -----END PGP SIGNATURE-----

d3drm: Add tests for querying between IDirect3DRM interfaces

[Henri Verbeet]

On 15 March 2015 at 11:50, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> You should not need this. If Direct3DRMCreate is not available
> InitFunctionPtrs() will return false and your test is never run.

In fact, I don't think the d3drm tests should need InitFunctionPtrs() either.