Re: [PATCH 6/6] ddraw/tests: Test creating flippable cubemaps.

[Bruno Jesus]

On Mon, Apr 25, 2016 at 12:25 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote:
> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>
> ---
>  dlls/ddraw/surface.c      |  2 ++
>  dlls/ddraw/tests/ddraw7.c | 50

Hi, the subject says you are adding tests but you also change dll
source, was it a leftover? Or maybe the subject should be changed to
reflect the source change IMO.

[PATCH 6/6] ddraw/tests: Test creating flippable cubemaps.

[Józef Kucia]

On Mon, Apr 25, 2016 at 2:00 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
> On Mon, Apr 25, 2016 at 12:25 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote:
> > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>
> > ---
> >  dlls/ddraw/surface.c      |  2 ++
> >  dlls/ddraw/tests/ddraw7.c | 50
>
> Hi, the subject says you are adding tests but you also change dll
> source, was it a leftover? Or maybe the subject should be changed to
> reflect the source change IMO.

Yes, it would be better to make this change in the patch 5/6.