Re: dsound: Fixed compilation error caused by 942f2ce7

[Jacek Caban]

Hi Alexander,

On 5/19/12 3:35 PM, Alexander E. Patrakov wrote:
> There is no dummy union u anymore.

This doesn't seem right. They are still present, just generated by widl.

Jacek

dsound: Fixed compilation error caused by 942f2ce7

[Alexander E. Patrakov]

2012/5/19 Jacek Caban <jacek(a)codeweavers.com>:
> Hi Alexander,
>
> On 5/19/12 3:35 PM, Alexander E. Patrakov wrote:
> > There is no dummy union u anymore.
>
> This doesn't seem right. They are still present, just generated by widl.
>
> Jacek

On my system, the generated propidl.h file contains this:

struct tagPROPVARIANT {

    VARTYPE vt;
    WORD wReserved1;
    WORD wReserved2;
    WORD wReserved3;
    __C89_NAMELESS union {
/* lots of fields */
    } __C89_NAMELESSUNIONNAME;
};

So indeed, my patch is wrong, it should use __C89_NAMELESSUNIONNAME
(which expands to nothing here) instead of nothing. Please reject it.

-- 
Alexander E. Patrakov

dsound: Fixed compilation error caused by 942f2ce7

[Alexander E. Patrakov]

OK, after a "make clean" and "make" it is clear that nothing needs to
be changed.

2012/5/19 Alexander E. Patrakov <patrakov(a)gmail.com>:
> 2012/5/19 Jacek Caban <jacek(a)codeweavers.com>:
> > Hi Alexander,
> >
> > On 5/19/12 3:35 PM, Alexander E. Patrakov wrote:
> > > There is no dummy union u anymore.
> >
> > This doesn't seem right. They are still present, just generated by widl.
> >
> > Jacek
>
> On my system, the generated propidl.h file contains this:
>
> struct tagPROPVARIANT {
>
>    VARTYPE vt;
>    WORD wReserved1;
>    WORD wReserved2;
>    WORD wReserved3;
>    __C89_NAMELESS union {
> /* lots of fields */
>    } __C89_NAMELESSUNIONNAME;
> };
>
> So indeed, my patch is wrong, it should use __C89_NAMELESSUNIONNAME
> (which expands to nothing here) instead of nothing. Please reject it.
>
> --
> Alexander E. Patrakov

-- 
Alexander E. Patrakov