Re: Paul Vriens : crypt32/tests: Cast-qual warning fixes.

[Michael Stefaniuc]

Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 259c06ffc93d690fa5105b1451e519aa1c92b72e
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=259c06ffc93d690fa5105b1451...
>
> Author: Paul Vriens <paul.vriens.wine(a)gmail.com>
> Date:   Fri Jan 12 15:51:02 2007 +0100
>
> crypt32/tests: Cast-qual warning fixes.

This breaks compilation with older gcc versions. At least with gcc-3.1.1
used by Smatch.

dlls/crypt32/tests/cert.c:312: invalid initializer
make[2]: *** [cert.o] Error 1
> @@ -309,8 +308,8 @@ static void checkHash(const BYTE *data,
>       propID);
>  }
>
> -static const WCHAR cspNameW[] = { 'W','i','n','e','C','r','y','p','t','T','e',
> - 'm','p',0 };
> +static WCHAR cspNameW[] = { 'W','i','n','e','C','r','y','p','t','T','e','m','p',0 };
> +static WCHAR ms_def_prov_w[] = MS_DEF_PROV_W;
> Making that 'static const WCHAR ms_def_prov_w[]' fixes the compilation
> error but renders the exercise moot.
> static void testCertProperties(void)
>  {

> ---
>
> dlls/crypt32/tests/cert.c |  113 ++++++++++++++++++++++-----------------------
>  1 files changed, 56 insertions(+), 57 deletions(-)
>
> Diff:   http://source.winehq.org/git/wine.git/?a=commitdiff;h=259c06ffc93d690fa5105b...

-- 
Michael Stefaniuc               Tel.: [phone]
Sr. Network Engineer            Fax.: [phone]
Red Hat GmbH                    Email: mstefani(a)redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart

Paul Vriens : crypt32/tests: Cast-qual warning fixes.

[Paul Vriens]

Michael Stefaniuc wrote:
> Alexandre Julliard wrote:
> > Module: wine
> > Branch: master
> > Commit: 259c06ffc93d690fa5105b1451e519aa1c92b72e
> > URL:    http://source.winehq.org/git/wine.git/?a=commit;h=259c06ffc93d690fa5105b1451...
> >
> > Author: Paul Vriens <paul.vriens.wine(a)gmail.com>
> > Date:   Fri Jan 12 15:51:02 2007 +0100
> >
> > crypt32/tests: Cast-qual warning fixes.
>
> This breaks compilation with older gcc versions. At least with gcc-3.1.1
> used by Smatch.
>
> dlls/crypt32/tests/cert.c:312: invalid initializer
> make[2]: *** [cert.o] Error 1

Hi,

I've sent 3 patches for this (crypt32/mshtml/secur32). I mentioned the 
compilation issues reported by Marcus this of course should have been Michael.

Cheers,

Paul.