Re: [2/4] tools: enable .lnk thumbnailing in Gnome
Damjan Jovanovic <damjan.jov(a)gmail.com> writes:
diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS) $(INSTALL_DATA) $(SRCDIR)/l_intl.nls $(DESTDIR)$(datadir)/wine/l_intl.nls $(INSTALL_DATA) $(SRCDIR)/wine.desktop $(DESTDIR)$(datadir)/applications/wine.desktop -$(UPDATE_DESKTOP_DATABASE) + gconftool --set -t string /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/command "wine winemenubuilder -t %i %o" || true + gconftool --set -t bool /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/enable "true" || true
There needs to be a better way of doing this. Probably filing a bug with freedesktop.org is in order. -- Alexandre Julliard julliard(a)winehq.org
On 07/26/2010 03:57 AM, Alexandre Julliard wrote:
Damjan Jovanovic <damjan.jov(a)gmail.com> writes:
diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS) $(INSTALL_DATA) $(SRCDIR)/l_intl.nls $(DESTDIR)$(datadir)/wine/l_intl.nls $(INSTALL_DATA) $(SRCDIR)/wine.desktop $(DESTDIR)$(datadir)/applications/wine.desktop -$(UPDATE_DESKTOP_DATABASE) + gconftool --set -t string /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/command "wine winemenubuilder -t %i %o" || true + gconftool --set -t bool /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/enable "true" || true
There needs to be a better way of doing this. Probably filing a bug with freedesktop.org is in order.
For sure. Thumbnailers are just shell scripts, but there is currently no cross distro way to enable them. My current "solution" is to just do this at the packaging layer and ignore KDE entirely until someone tells me the equivalent of installing gconf schemas, but this is obviously not good. Thanks, Scott Ritchie
On Wed, Jul 28, 2010 at 2:54 AM, Scott Ritchie <scott(a)open-vote.org> wrote:
On 07/26/2010 03:57 AM, Alexandre Julliard wrote:
Damjan Jovanovic <damjan.jov(a)gmail.com> writes:
diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS) $(INSTALL_DATA) $(SRCDIR)/l_intl.nls $(DESTDIR)$(datadir)/wine/l_intl.nls $(INSTALL_DATA) $(SRCDIR)/wine.desktop $(DESTDIR)$(datadir)/applications/wine.desktop -$(UPDATE_DESKTOP_DATABASE) + gconftool --set -t string /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/command "wine winemenubuilder -t %i %o" || true + gconftool --set -t bool /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/enable "true" || true
There needs to be a better way of doing this. Probably filing a bug with freedesktop.org is in order.
For sure. Thumbnailers are just shell scripts, but there is currently no cross distro way to enable them.
My current "solution" is to just do this at the packaging layer and ignore KDE entirely until someone tells me the equivalent of installing gconf schemas, but this is obviously not good.
Thanks, Scott Ritchie
freedesktop.org has a spec for a shared thumbnail cache (http://triq.net/~jens/thumbnail-spec/index.html), but no accepted spec for a file browser to request that a file be thumbnailed: there's a draft DBUS thumbnailing spec that's been heavily discussed last year but it still isn't ready or adopted by any/most desktops (http://live.gnome.org/ThumbnailerSpec). I was thinking that what we could do, is when we generate a .lnk file on the desktop, we also write a thumbnail for it to the shared thumbnail cache - that way the desktop environment doesn't need to ask us to generate a thumbnail since it already exists. But then the cache could be cleared out periodically meaning we'd eventually lose the thumbnail. Winemenubuilder could work around this by regenerating all thumbnails that are missing on every startup. But even if this is acceptable solution, it's still hard to implement, because the thumbnail cache spec requires specific thumbnail sizes (128x128 or 256x256) and a special pixel format (256 colour indexed-mode PNG IIRC) which means we'd need to resize and colour convert the icon(s), and it needs special PNG comments on the thumbnails which windowscodecs doesn't support even on Windows AFAIK. So is this idea viable? Thank you Damjan Jovanovic
On 07/28/2010 12:36 AM, Damjan Jovanovic wrote:
freedesktop.org has a spec for a shared thumbnail cache (http://triq.net/~jens/thumbnail-spec/index.html), but no accepted spec for a file browser to request that a file be thumbnailed: there's a draft DBUS thumbnailing spec that's been heavily discussed last year but it still isn't ready or adopted by any/most desktops (http://live.gnome.org/ThumbnailerSpec).
I was thinking that what we could do, is when we generate a .lnk file on the desktop, we also write a thumbnail for it to the shared thumbnail cache - that way the desktop environment doesn't need to ask us to generate a thumbnail since it already exists. But then the cache could be cleared out periodically meaning we'd eventually lose the thumbnail. Winemenubuilder could work around this by regenerating all thumbnails that are missing on every startup. But even if this is acceptable solution, it's still hard to implement, because the thumbnail cache spec requires specific thumbnail sizes (128x128 or 256x256) and a special pixel format (256 colour indexed-mode PNG IIRC) which means we'd need to resize and colour convert the icon(s), and it needs special PNG comments on the thumbnails which windowscodecs doesn't support even on Windows AFAIK. So is this idea viable?
That spec will need to be updated. Gnome recently started supporting thumbnails that are smaller than the overly large 128x128 (actually I think it was 96x96 originally). gnome-exe-thumbnailer now relies on this behavior to render properly, in the past when it was forced to large sizes it looked incredibly ugly. Thanks, Scott Ritchie
According to MSDN http://msdn.microsoft.com/en-us/library/ee719797%28VS.85%29.aspx#png__image_..., WIC can save indexed color PNG's on Windows. You just need to give it 8-bit indexed image data. Wine's WIC does not support this, but I can work on adding support if there's a real need.
On 28.07.2010 09:36, Damjan Jovanovic wrote:
thumbnails that are missing on every startup. But even if this is acceptable solution, it's still hard to implement, because the thumbnail cache spec requires specific thumbnail sizes (128x128 or 256x256) and a special pixel format (256 colour indexed-mode PNG IIRC)
Differing sizes are no problems. Prominent example: if you have picture with an aspect ratio other than 1, the thumbnail won't be square. The file managers usually handle that quite fine ... The spec actually says that thumbnails for small images don't have to be saved; though in practice I'd expect that a 32x32 sized thumbnail shows up as 32x32 (and not scaled up or so). Colors: spec says “it must be a 8bit, non-interlaced PNG image with full alpha transparency”. It's somewhat ambiguous, but indexed colors seem unlikely - 32bit RGBA images (ie 8 bit per channel) is what every thumbnailer practically creates. Link for above info: http://jens.triq.net/thumbnail-spec/creation.html -f.r.
On Wed, Jul 28, 2010 at 5:11 PM, Frank Richter <frank.richter(a)gmail.com> wrote:
On 28.07.2010 09:36, Damjan Jovanovic wrote:
thumbnails that are missing on every startup. But even if this is acceptable solution, it's still hard to implement, because the thumbnail cache spec requires specific thumbnail sizes (128x128 or 256x256) and a special pixel format (256 colour indexed-mode PNG IIRC)
Differing sizes are no problems. Prominent example: if you have picture with an aspect ratio other than 1, the thumbnail won't be square. The file managers usually handle that quite fine ...
The spec actually says that thumbnails for small images don't have to be saved; though in practice I'd expect that a 32x32 sized thumbnail shows up as 32x32 (and not scaled up or so).
Colors: spec says “it must be a 8bit, non-interlaced PNG image with full alpha transparency”. It's somewhat ambiguous, but indexed colors seem unlikely - 32bit RGBA images (ie 8 bit per channel) is what every thumbnailer practically creates.
Link for above info: http://jens.triq.net/thumbnail-spec/creation.html
-f.r.
The PNG thumbnail attributes are the problem then. They require WIC to support metadata writing, which Wine's doesn't atm. Damjan
On 07/28/2010 08:54 AM, Scott Ritchie wrote:
On 07/26/2010 03:57 AM, Alexandre Julliard wrote:
Damjan Jovanovic<damjan.jov(a)gmail.com> writes:
diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS) $(INSTALL_DATA) $(SRCDIR)/l_intl.nls $(DESTDIR)$(datadir)/wine/l_intl.nls $(INSTALL_DATA) $(SRCDIR)/wine.desktop $(DESTDIR)$(datadir)/applications/wine.desktop -$(UPDATE_DESKTOP_DATABASE) + gconftool --set -t string /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/command "wine winemenubuilder -t %i %o" || true + gconftool --set -t bool /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/enable "true" || true
There needs to be a better way of doing this. Probably filing a bug with freedesktop.org is in order.
For sure. Thumbnailers are just shell scripts, but there is currently no cross distro way to enable them.
My current "solution" is to just do this at the packaging layer and ignore KDE entirely until someone tells me the equivalent of installing gconf schemas, but this is obviously not good.
Thanks, Scott Ritchie
Inspired by reading this in the newsgroup, I've thrown together a KDE plugin to do .lnk thumbnailing. (KDE already has the ability to preview exe files using icotools, which I didn't realise!) I don't suppose the code belongs in the wine project (for a number of reasons, not least of which it's C++). If anyone's interested, though, it's available at http://code.google.com/p/kdewinelnkthumbnailer/ It'd be great if there was a cross-desktop way to do all of this... - Nicholas van Oudtshoorn (It's been a while since I've done any coding work, so it's probably not the most beautiful code! But it works!)
On 07/28/2010 08:54 AM, Scott Ritchie wrote:
On 07/26/2010 03:57 AM, Alexandre Julliard wrote:
Damjan Jovanovic<damjan.jov(a)gmail.com> writes:
diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS) $(INSTALL_DATA) $(SRCDIR)/l_intl.nls $(DESTDIR)$(datadir)/wine/l_intl.nls $(INSTALL_DATA) $(SRCDIR)/wine.desktop $(DESTDIR)$(datadir)/applications/wine.desktop -$(UPDATE_DESKTOP_DATABASE) + gconftool --set -t string /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/command "wine winemenubuilder -t %i %o" || true + gconftool --set -t bool /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/enable "true" || true
There needs to be a better way of doing this. Probably filing a bug with freedesktop.org is in order.
For sure. Thumbnailers are just shell scripts, but there is currently no cross distro way to enable them.
My current "solution" is to just do this at the packaging layer and ignore KDE entirely until someone tells me the equivalent of installing gconf schemas, but this is obviously not good.
Thanks, Scott Ritchie
Inspired by reading this in the newsgroup, I've thrown together a KDE plugin to do .lnk thumbnailing. I don't suppose the code belongs in the wine project (for a number of reasons, not least of which it's C++). If anyone's interested, though, it's available at http://code.google.com/p/kdewinelnkthumbnailer/ It'd be great if there was a cross-desktop way to do all of this... - Nicholas van Oudtshoorn (It's been a while since I've done any coding work, so it's probably not the most beautiful code! But it works!)
participants (6)
-
Alexandre Julliard -
Damjan Jovanovic -
Frank Richter -
Nicholas van Oudtshoorn -
Scott Ritchie -
Vincent Povirk