Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable

[Huw Davies]

On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote:
> +typedef struct {
> +    WORD LigatureAnchor[1];
> +} GPOS_ComponentRecord;
> +
> +typedef struct {
> +    WORD ComponentCount;
> +    GPOS_ComponentRecord ComponentRecord[1];
> +} GPOS_LigatureAttach;
> +
> +                    for (i = 0; i < component_count && !offset; i++)
> +                    {
> +                        int k;
> +                        for (k = 0; k < class_count && !offset; k++)
> +                            offset = GET_BE_WORD(lt->ComponentRecord[i].LigatureAnchor[k]);
> +                    }

Hi Aric,

This can't work as ComponentRecord is a variable-sized struct.

Huw.

usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable

[Aric Stewart]

Ah, yes, you corrected that in another area also.  I will rewrite.

-aric

On 13/01/09 12:02, Huw Davies wrote:
> On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote:
> > +typedef struct {
> > +    WORD LigatureAnchor[1];
> > +} GPOS_ComponentRecord;
> > +
> > +typedef struct {
> > +    WORD ComponentCount;
> > +    GPOS_ComponentRecord ComponentRecord[1];
> > +} GPOS_LigatureAttach;
> > +
> > +                    for (i = 0; i < component_count && !offset; i++)
> > +                    {
> > +                        int k;
> > +                        for (k = 0; k < class_count && !offset; k++)
> > +                            offset = GET_BE_WORD(lt->ComponentRecord[i].LigatureAnchor[k]);
> > +                    }
>
> Hi Aric,
>
> This can't work as ComponentRecord is a variable-sized struct.
>
> Huw.