Re: winex11.drv: Remove an incorrect FIXME

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:
> diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c
> index f2bf12c..948c58c 100644
> --- a/dlls/winex11.drv/x11drv_main.c
> +++ b/dlls/winex11.drv/x11drv_main.c
> @@ -498,10 +498,7 @@ static BOOL process_attach(void)
>              break;
>
> case 15:
> -            /* Out tests suggest that windows does not support 15 bpp color depth.
> -             * X11 does, what should we do with these situations?
> -             */
> -            FIXME("The X server is running at 15 bpp color depth\n");
> +            /* It's the same thing as 16 bpp but with different bit fields */
>              screen_bpp = 15;

Shouldn't screen_bpp be set to 16 then?

-- 
Alexandre Julliard
julliard(a)winehq.org

winex11.drv: Remove an incorrect FIXME

[Dmitry Timoshkov]

"Alexandre Julliard" <julliard(a)winehq.org> wrote:
> > case 15:
> > -            /* Out tests suggest that windows does not support 15 bpp color depth.
> > -             * X11 does, what should we do with these situations?
> > -             */
> > -            FIXME("The X server is running at 15 bpp color depth\n");
> > +            /* It's the same thing as 16 bpp but with different bit fields */
> >              screen_bpp = 15;
>
> Shouldn't screen_bpp be set to 16 then?

I believe that GetDeviceCaps(BITSPIXEL) should return 15 in that case,
so that the apps would use correct bit fields for DIBs.

-- 
Dmitry.

winex11.drv: Remove an incorrect FIXME

[Alexandre Julliard]

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes:
> "Alexandre Julliard" <julliard(a)winehq.org> wrote:
> > Shouldn't screen_bpp be set to 16 then?
>
> I believe that GetDeviceCaps(BITSPIXEL) should return 15 in that case,
> so that the apps would use correct bit fields for DIBs.

There are no "correct bit fields" for DIBs, by definition DIBs are
display-independent, and we have to support both bit field variants on
all displays, so the actual screen depth is irrelevant.

-- 
Alexandre Julliard
julliard(a)winehq.org