Re: [3/5] strmbase: Add validation checks when updating destination rectangle.

[Andrew Eikum]

On Sun, Nov 20, 2016 at 03:33:24PM +0900, Akihiro Sagawa wrote:
> @@ -409,13 +438,19 @@ HRESULT WINAPI BaseControlVideoImpl_put_DestinationHeight(IBasicVideo *iface, LO
>  {
>      RECT DestRect;
>      BaseControlVideo *This = impl_from_IBasicVideo(iface);
> +    HRESULT hr;
>
> TRACE("(%p/%p)->(%d)\n", This, iface, DestinationHeight);
> -    This->pFuncsTable->pfnGetTargetRect(This, &DestRect);
> -    DestRect.right = DestRect.left + DestinationHeight;
> -    This->pFuncsTable->pfnSetTargetRect(This, &DestRect);
> +    hr = This->pFuncsTable->pfnGetTargetRect(This, &DestRect);
> +    if (SUCCEEDED(hr))
> +    {
> +        DestRect.right = DestRect.left + DestinationHeight;

You've got a copy-paste error here, unfortunately.

Andrew