visual regression in IE

[Joris Huizer]

Hello,

I tried to search for information on regressions on the winehq site but 
I couldn't find it (maybe it should be made visible on the documentation 
page?)

Anyway, in internet explorer a visual regression happened: with my 
previous cvs build from 15 march, things were displayed correctly, but 
now (cvs build from 23 march) the 'address' and the 'links' fields are 
displayed incorrectly: they are bigger than they should be, and they are 
'striked through' which should not happen; See also the attached 
screenshots - I'm sure it's clear what I mean;

Could someone point me to the correct pages to find out what caused 
this? I'm sure someone will be fix this a lot faster than I could do but 
I want to learn how to solve such a problem :)

regards,

Joris

[James Hawkins]

On Thu, 24 Mar 2005 23:39:22 +0100, Joris Huizer <jorishuizer(a)planet.nl> wrote:
> Could someone point me to the correct pages to find out what caused
> this? I'm sure someone will be fix this a lot faster than I could do but
> I want to learn how to solve such a problem :)

You could run a regression test.
http://www.winehq.org/site/docs/wine-devel/x1318

-- 
James Hawkins

[Joris Huizer]

James Hawkins wrote:
> On Thu, 24 Mar 2005 23:39:22 +0100, Joris Huizer <jorishuizer(a)planet.nl> wrote:
> > Could someone point me to the correct pages to find out what caused
> > this? I'm sure someone will be fix this a lot faster than I could do but
> > I want to learn how to solve such a problem :)
>
> You could run a regression test.
> http://www.winehq.org/site/docs/wine-devel/x1318

Okay, I found the regression happened some time on 23 march:
   cvs update -PAd -D "2005-03-23 CDT" doesn't have the regression
   cvs update -PAd -D "2005-03-24 CDT" has the regression

Now how will I be able to find exactly what's causing it? Can I download 
the individual patch files of that date somehow?

Thanks for any pointers :)

regards,

Joris

[Paul van Schayck]

On Sat, 26 Mar 2005 11:05:27 +0100, Joris Huizer <jorishuizer(a)planet.nl> wrote:
> James Hawkins wrote:
> Okay, I found the regression happened some time on 23 march:
>    cvs update -PAd -D "2005-03-23 CDT" doesn't have the regression
>    cvs update -PAd -D "2005-03-24 CDT" has the regression
>
> Now how will I be able to find exactly what's causing it? Can I download
> the individual patch files of that date somehow?

http://www.winehq.org/hypermail/wine-cvs/2005/03/index.html

That shows all the cvs patches. I would try the comctrl patches from
the 23th. Not things like winealsa.

Paul

[Hannu Valtonen]

Joris Huizer wrote:
> James Hawkins wrote:
> > On Thu, 24 Mar 2005 23:39:22 +0100, Joris Huizer 
> > <jorishuizer(a)planet.nl> wrote:
> > > Could someone point me to the correct pages to find out what caused
> > > this? I'm sure someone will be fix this a lot faster than I could do but
> > > I want to learn how to solve such a problem :)
> >
> > You could run a regression test.
> > http://www.winehq.org/site/docs/wine-devel/x1318
>
> Okay, I found the regression happened some time on 23 march:
>   cvs update -PAd -D "2005-03-23 CDT" doesn't have the regression
>   cvs update -PAd -D "2005-03-24 CDT" has the regression
>
> Now how will I be able to find exactly what's causing it? Can I download 
> the individual patch files of that date somehow?

You can update by time as well as by year/month/day. Just look at the 
wine-cvs list archives for potential times to update to.

eg. cvs update -PAd -D "2005-03-23 16:00"

- Hannu Valtonen
Hannu.Valtonen(a)hut.fi

[Robert Shearman]

Joris Huizer wrote:
> James Hawkins wrote:
> > On Thu, 24 Mar 2005 23:39:22 +0100, Joris Huizer 
> > <jorishuizer(a)planet.nl> wrote:
> > > Could someone point me to the correct pages to find out what caused
> > > this? I'm sure someone will be fix this a lot faster than I could do 
> > > but
> > > I want to learn how to solve such a problem :)
> >
> > You could run a regression test.
> > http://www.winehq.org/site/docs/wine-devel/x1318
>
> Okay, I found the regression happened some time on 23 march:
>   cvs update -PAd -D "2005-03-23 CDT" doesn't have the regression
>   cvs update -PAd -D "2005-03-24 CDT" has the regression
>
> Now how will I be able to find exactly what's causing it? Can I 
> download the individual patch files of that date somehow?

Thanks for narrowing the regression down.

Does the attached patch help?

Rob

[Joris Huizer]

Robert Shearman wrote:
> Joris Huizer wrote:
> > James Hawkins wrote:
> > > On Thu, 24 Mar 2005 23:39:22 +0100, Joris Huizer 
> > > <jorishuizer(a)planet.nl> wrote:
> > > > Could someone point me to the correct pages to find out what caused
> > > > this? I'm sure someone will be fix this a lot faster than I could do 
> > > > but
> > > > I want to learn how to solve such a problem :)
> > >
> > > You could run a regression test.
> > > http://www.winehq.org/site/docs/wine-devel/x1318
> >
> > Okay, I found the regression happened some time on 23 march:
> >   cvs update -PAd -D "2005-03-23 CDT" doesn't have the regression
> >   cvs update -PAd -D "2005-03-24 CDT" has the regression
> >
> > Now how will I be able to find exactly what's causing it? Can I 
> > download the individual patch files of that date somehow?
>
> Thanks for narrowing the regression down.
>
> Does the attached patch help?
>
> Rob

Yeah, after applying the patch IE draws its bar normally again :)
(Also I think I got closer to being able to do regression testing now)

Thanks,

regards,

Joris
> ------------------------------------------------------------------------
>
> Index: dlls/comctl32/rebar.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/comctl32/rebar.c,v
> retrieving revision 1.107
> diff -u -p -r1.107 rebar.c
> --- dlls/comctl32/rebar.c	23 Mar 2005 13:15:21 -0000	1.107
> +++ dlls/comctl32/rebar.c	26 Mar 2005 20:27:04 -0000
> @@ -4122,7 +4122,7 @@ REBAR_NCCreate (HWND hwnd, WPARAM wParam
>      SetWindowLongW (hwnd, GWL_STYLE, infoPtr->dwStyle);
>
> /* get font handle for Caption Font */
> -    ncm.cbSize = sizeof(NONCLIENTMETRICSA);
> +    ncm.cbSize = sizeof(ncm);
>      SystemParametersInfoW (SPI_GETNONCLIENTMETRICS, ncm.cbSize, &ncm, 0);
>      /* if the font is bold, set to normal */
>      if (ncm.lfCaptionFont.lfWeight > FW_NORMAL) {