[PATCH] dlls/kernel32/tests: correctly handle shell_no_window console in process.c
should fix testbot daily failures for kernel32:process Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/kernel32/tests/process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 8f18a0d37a7..dfb72fae7b7 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -1543,6 +1543,8 @@ static void test_Console(void) /* first, we need to be sure we're attached to a console */ if (!is_console(startup.hStdInput) || !is_console(startup.hStdOutput)) { + /* could be attached to a shell_no_window console, so always detach */ + FreeConsole(); /* we're not attached to a console, let's do it */ AllocConsole(); startup.hStdInput = CreateFileA("CONIN$", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0);
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=112638 Your paranoid android. === w7u_el (32 bit report) === kernel32: process.c:4977: Test failed: got 0xc0000004 process.c:4993: Test failed: services.exe not found === w8 (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 0e6c === w8adm (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 08c0 === w864 (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 0644 === w1064v1507 (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 0dac === w1064v1809 (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1f78 === w1064 (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1e50 === w1064_tsign (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 023c === w10pro64 (32 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 2048 === w864 (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 0474 === w1064v1507 (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 0d04 === w1064v1809 (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1b00 === w1064 (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1d84 === w1064_2qxl (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1684 === w1064_tsign (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1cbc === w10pro64 (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 03ac === w10pro64_ar (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1c18 process.c:4296: Test failed: Unexpected return value, error 203. === w10pro64_he (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 2230 === w10pro64_ja (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 1ee4 === w10pro64_zh_CN (64 bit report) === kernel32: process.c:212: unhandled exception c0000142 in child process 20ec === debian11 (32 bit Hindi:India report) === kernel32: process.c:1584: Test failed: GetLastError: expecting 87 got 6 process.c:1594: Test failed: GetLastError: expecting 87 got 6
participants (2)
-
Eric Pouech -
Marvin