[PATCH 2/2] wininet: Correct behaviour of error masking.

[Owen Rudge]

Signed-off-by: Owen Rudge <orudge(a)codeweavers.com>
---
  dlls/wininet/netconnection.c | 16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=57381

Your paranoid android.


=== debian10 (32 bit report) ===

wininet:
ftp.c:81: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110
ftp.c:112: Test failed: InternetConnect failed : 12110
ftp.c:113: Test failed: ERROR_SUCCESS, got 12110
ftp.c:122: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110
http.c:4777: Test failed: expected 1 pending read, got 2

=== debian10 (32 bit Chinese:China report) ===

wininet:
ftp.c:81: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110
ftp.c:112: Test failed: InternetConnect failed : 12110
ftp.c:113: Test failed: ERROR_SUCCESS, got 12110
ftp.c:122: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110

[Owen Rudge]

On 03/10/2019 23:19, Marvin wrote:
> === debian10 (32 bit report) ===
>
> wininet:
> ftp.c:81: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110
> ftp.c:112: Test failed: InternetConnect failed : 12110
> ftp.c:113: Test failed: ERROR_SUCCESS, got 12110
> ftp.c:122: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110
> http.c:4777: Test failed: expected 1 pending read, got 2

The FTP failures are unrelated, and the one-off http failure seems to be 
a flaky test.

Owen

[Alexandre Julliard]

Owen Rudge <orudge(a)codeweavers.com> writes:
> Signed-off-by: Owen Rudge <orudge(a)codeweavers.com>
> ---
>  dlls/wininet/netconnection.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

It breaks the tests:

../../../tools/runtest -q -P wine -T ../../.. -M urlmon.dll -p urlmon_test.exe url && touch url.ok
url.c:1364: Test failed: Got problem: 12055
url.c:1879: Test failed: binding failed: 800c0019, expected 800c000e
url.c:3101: Test failed: Got 800c0019
url.c:1879: Test failed: binding failed: 800c0019, expected 800c000e
url.c:1879: Test failed: binding failed: 80004004, expected 800c000e
url.c:1879: Test failed: binding failed: 800c0019, expected 800c000e
make: *** [Makefile:403: url.ok] Error 6

-- 
Alexandre Julliard
julliard(a)winehq.org