Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access()
On Sun, Jun 6, 2010 at 2:50 AM, Austin English <austinenglish(a)gmail.com> wrote:
See http://bugs.winehq.org/show_bug.cgi?id=23003
-- -Austin
You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.
On Sun, Jun 6, 2010 at 3:27 AM, Andrew Nguyen <arethusa26(a)gmail.com> wrote:
On Sun, Jun 6, 2010 at 2:50 AM, Austin English <austinenglish(a)gmail.com> wrote:
See http://bugs.winehq.org/show_bug.cgi?id=23003
-- -Austin
You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.
Good call, thanks for catching. -- -Austin
Hello, On 06-06-10 21:09, Austin English wrote:
On Sun, Jun 6, 2010 at 3:27 AM, Andrew Nguyen<arethusa26(a)gmail.com> wrote:
On Sun, Jun 6, 2010 at 2:50 AM, Austin English<austinenglish(a)gmail.com> wrote:
See http://bugs.winehq.org/show_bug.cgi?id=23003
-- -Austin
You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.
Good call, thanks for catching.
Is snd_pcm_recover the only function missing? If so change it to dlsym, and add a copy of snd_pcm_recover to wine if it cannot find the libalsa one.. Cheers, Maarten
On Sun, Jun 6, 2010 at 4:03 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote:
Is snd_pcm_recover the only function missing? If so change it to dlsym, and add a copy of snd_pcm_recover to wine if it cannot find the libalsa one..
Is it a problem to eschew the use of dlsym? It feels like modifying winealsa.drv to dynamically load libasound correctly would be much more burdensome than simply replicating the snd_pcm_recover implementation. I have a provisional patch that replaces a half-baked snd_pcm_recover-like internal helper with the actual snd_pcm_recover implementation from libasound. I would welcome any feedback on it.
Hello Andrew, On 11-06-10 10:18, Andrew Nguyen wrote:
On Sun, Jun 6, 2010 at 4:03 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote:
Is snd_pcm_recover the only function missing? If so change it to dlsym, and add a copy of snd_pcm_recover to wine if it cannot find the libalsa one..
Is it a problem to eschew the use of dlsym? It feels like modifying winealsa.drv to dynamically load libasound correctly would be much more burdensome than simply replicating the snd_pcm_recover implementation. I have a provisional patch that replaces a half-baked snd_pcm_recover-like internal helper with the actual snd_pcm_recover implementation from libasound. I would welcome any feedback on it.
Nah, I dislike the overuse of dlsym in wine too. Can you name the function wine_snd_pcm_recover, and fix the SNDERR() macro's? Otherwise looks good to me. ~Maarten
On Fri, Jun 11, 2010 at 3:34 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote:
Hello Andrew,
On 11-06-10 10:18, Andrew Nguyen wrote:
On Sun, Jun 6, 2010 at 4:03 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote:
Is snd_pcm_recover the only function missing? If so change it to dlsym, and add a copy of snd_pcm_recover to wine if it cannot find the libalsa one..
Is it a problem to eschew the use of dlsym? It feels like modifying winealsa.drv to dynamically load libasound correctly would be much more burdensome than simply replicating the snd_pcm_recover implementation. I have a provisional patch that replaces a half-baked snd_pcm_recover-like internal helper with the actual snd_pcm_recover implementation from libasound. I would welcome any feedback on it.
Nah, I dislike the overuse of dlsym in wine too.
Can you name the function wine_snd_pcm_recover, and fix the SNDERR() macro's? Otherwise looks good to me.
~Maarten
Done. I've sent a final patch.
participants (3)
-
Andrew Nguyen -
Austin English -
Maarten Lankhorst