Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs

[Matteo Bruni]

2013/7/30 Chris Moeller <kode54(a)gmail.com>:
> On Jul 29, 2013, at 11:22 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
> > 2013/7/29 Chris Moeller <kode54(a)gmail.com>:
> > > without looking very deeply into the CRT source code.
> >
> > You're talking about MS source code, right? That makes you tainted for
> > contributing to Wine at
> > the very least for C runtime-related code :(
> > If you haven't looked into any other source code, this patch might be
> > okay (barring other issues, I haven't read the patch at all). At least
> > http://wiki.winehq.org/DeveloperFaq#head-fed5011434f62ae1a88baebfb8193a37ea7...
> > seems to suggest so.
>
> I did not look at any CRT source code to determine how to implement the functionality of this patch. I only looked at CRT source code to determine why the CRT was crashing in the first place. The HighestNode function popping a warning in my wine logs should have been hint enough to discover that function was stubbed.
>
> I actually determined how these functions worked by testing their behavior against a working system, and also with the aid of another developer, who pointed out a handy Win32 function for retrieving a suitable value for the free memory check.

That's probably fine, although as a general rule you should stay as
far as possible from Microsoft's source code.

Cheers,
Matteo.