Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

[Frédéric Delanoy]

On Tue, Sep 6, 2011 at 09:35, Christian Costa <titan.costa(a)wanadoo.fr> wrote:
> --
>
> It's just a resend. The patch is unmodified, just rebased on latest git.
>
> try4:
> - add missing NULL ending character to help_option string
>
> try3:
> - fix /? option. This fixes cmd tests regression
>
> try2:
> - keep attrib infos for help command
> - update po files
>
> I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy.

I've got test failures with your patch ("make test" in programs/cmd/tests)
First error:
batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591
(got 'r.test not found before delete, bad', wanted 'r.test found
before delete, good')

Also, beware that testbot won't test your patch on windowses since it
doesn't change any file in tests/ directory
(you might want to submit it manually with, say, a small change in
test_builtins.cmd and/or test_builtins.exp)

See http://wiki.winehq.org/CmdConformanceTests (recently written) if
you need help with the keywords, etc.

Frédéric

[PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

[Christian Costa]

On 06/09/2011 15:33, Frédéric Delanoy wrote:
> On Tue, Sep 6, 2011 at 09:35, Christian Costa<titan.costa(a)wanadoo.fr>  wrote:
> > --
> >
> > It's just a resend. The patch is unmodified, just rebased on latest git.
> >
> > try4:
> > - add missing NULL ending character to help_option string
> >
> > try3:
> > - fix /? option. This fixes cmd tests regression
> >
> > try2:
> > - keep attrib infos for help command
> > - update po files
> >
> > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy.
> > I've got test failures with your patch ("make test" in programs/cmd/tests)
> > First error:
> > batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591
> > (got 'r.test not found before delete, bad', wanted 'r.test found
> > before delete, good')
>
> Also, beware that testbot won't test your patch on windowses since it
> doesn't change any file in tests/ directory
> (you might want to submit it manually with, say, a small change in
> test_builtins.cmd and/or test_builtins.exp)
>
> See http://wiki.winehq.org/CmdConformanceTests (recently written) if
> you need help with the keywords, etc.
>
> Frédéric

I don't have such an error here. Are you sure it is my patch that causes 
this ?
Line 591 does not say much. Is it in the .cmd file or the .cmd.exp one. 
What is the failing command ?
I don't see the point with testbot, there is no tests change in my patch.

Christian

[PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

[Frédéric Delanoy]

> I don't have such an error here. Are you sure it is my patch that causes
> this ?
> Line 591 does not say much. Is it in the .cmd file or the .cmd.exp one. What
> is the failing command ?
> I don't see the point with testbot, there is no tests change in my patch.

Don't have the error anymore, probably a temporary local glitch.
For the testbot, that was effectively an error of me, since win
obviously doesn't run cmd parsing code.
When Dan's buildbot is stable enough, we could however test changes there.

Sorry for the noise.

Frédéric