Re: kernel32: WideCharToMultiByte: return error on negative dest len

[James Hawkins]

On Fri, Mar 21, 2008 at 6:43 PM, Dan Kegel <dank(a)kegel.com> wrote:
> While investigating a crash in gs-auftrag in bug 9039, noticed
>  WideCharToMultiByte
>  wasn't quite conformant for negative destlen.  Fixed, with tests.

> diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c
> index 1130349..2decf85 100644
> --- a/dlls/kernel32/locale.c
> +++ b/dlls/kernel32/locale.c
> @@ -31,6 +31,7 @@ #include <stdarg.h>
>  #include <stdio.h>
>  #include <ctype.h>
>  #include <stdlib.h>
> +#include <limits.h>
>
> #ifdef __APPLE__
>  # include <CoreFoundation/CFBundle.h>

Leftover from a previous version of the patch?

-- 
James Hawkins

kernel32: WideCharToMultiByte: return error on negative dest len

[Dan Kegel]

On Fri, Mar 21, 2008 at 7:12 PM, James Hawkins <truiken(a)gmail.com> wrote:
> > +#include <limits.h>
>
> Leftover from a previous version of the patch?

Whoops, yes.  I'll resend it Monday.