Re: [PATCH 4/5] msxml3: Added partial XMLView IPersistMoniker_Load implementation

[Alexandre Julliard]

Piotr Caban <piotr(a)codeweavers.com> writes:
> ---
>  dlls/msxml3/xmlview.c |  908
> ++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 904 insertions(+), 4 deletions(-)

This doesn't build without libxml (missing domdoc functions).

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 4/5] msxml3: Added partial XMLView IPersistMoniker_Load implementation

[Nikolay Sivov]

On 3/12/2012 18:44, Alexandre Julliard wrote:
> Piotr Caban<piotr(a)codeweavers.com>  writes:
> > ---
> >   dlls/msxml3/xmlview.c |  908
> > ++++++++++++++++++++++++++++++++++++++++++++++++-
> >   1 files changed, 904 insertions(+), 4 deletions(-)
> > This doesn't build without libxml (missing domdoc functions).

This also kind of breaks implementation separation. You're doing a 
CoCreateInstance() and calling internal function in the same time, that 
relies on domdoc implementation. Why not to load it from url directly?