Wine Gecko 2.47.1 is not compatible with Python 2 or 3
Hi Jacek, Trying to build 2.47.1 on Fedora Rawhide (32) results in failures for both Python 3 and Python 2. Python 3: ... File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/testing/mozbase/mozinfo/mozinfo/mozinfo.py", line 93, in <module> (distro, os_version, codename) = platform.dist() AttributeError: module 'platform' has no attribute 'dist' Python 2: ... File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/build/mach_bootstrap.py", line 331 print(NO_MERCURIAL_SETUP.format(mach=sys.argv[0]), file=sys.stderr) ^ SyntaxError: invalid syntax Am I missing something? Thanks, Michael
On 19/12/2019 22:48, Michael Cronenworth wrote:
Hi Jacek,
Trying to build 2.47.1 on Fedora Rawhide (32) results in failures for both Python 3 and Python 2.
Python 3: ... File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/testing/mozbase/mozinfo/mozinfo/mozinfo.py", line 93, in <module> (distro, os_version, codename) = platform.dist() AttributeError: module 'platform' has no attribute 'dist'
This code path is taken only when linux_distribution() is not available and, according to documentation, it should be available since version 2.6. Please look at why it's not available. Thanks, Jacek
On 12/19/19 4:37 PM, Jacek Caban wrote:
This code path is taken only when linux_distribution() is not available and, according to documentation, it should be available since version 2.6. Please look at why it's not available.
Python 3.8 removes dist() and linux_distribution(). Fedora 32+ will use Python 3.8. https://bugs.python.org/issue28167
On 12/19/19 11:53 PM, Michael Cronenworth wrote:
On 12/19/19 4:37 PM, Jacek Caban wrote:
This code path is taken only when linux_distribution() is not available and, according to documentation, it should be available since version 2.6. Please look at why it's not available.
Python 3.8 removes dist() and linux_distribution(). Fedora 32+ will use Python 3.8.
So if we'd like to support all Python version, we'd need a third branch using the distro package and hope it will work for at least a few years... Great job, Python. Let's not do that. Does the attached patch help? git grep suggests that that may be a few more usages in the tree, but most of them may not be relevant to our builds. Jacek
On 12/20/19 10:51 AM, Jacek Caban wrote:
Let's not do that. Does the attached patch help? git grep suggests that that may be a few more usages in the tree, but most of them may not be relevant to our builds.
It does help get past that usage of dist() but there are other uses of it further on. ... 0:03.26$<2> File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/python/virtualenv/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/download.py", line 92, in user_agent 0:03.26$<2> zip(["name", "version", "id"], platform.linux_distribution()), 0:03.26$<2> AttributeError: module 'platform' has no attribute 'linux_distribution' Being inside of a zipped file I'm not sure the best way to patch that one. :(
On 12/20/19 6:05 PM, Michael Cronenworth wrote:
On 12/20/19 10:51 AM, Jacek Caban wrote:
Let's not do that. Does the attached patch help? git grep suggests that that may be a few more usages in the tree, but most of them may not be relevant to our builds.
It does help get past that usage of dist() but there are other uses of it further on.
... 0:03.26$<2> File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/python/virtualenv/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl/pip/download.py", line 92, in user_agent 0:03.26$<2> zip(["name", "version", "id"], platform.linux_distribution()), 0:03.26$<2> AttributeError: module 'platform' has no attribute 'linux_distribution'
Being inside of a zipped file I'm not sure the best way to patch that one. :(
Does it help if you cherry-pick commit 8812ca17fd5c720fc? Thanks, Jacek
On 12/23/19 7:12 PM, Michael Cronenworth wrote:
On 12/23/19 10:47 AM, Jacek Caban wrote:
Does it help if you cherry-pick commit 8812ca17fd5c720fc?
I can't find that commit. Are you still using sourceforge?
That was from my import, I missed the fact that it's too new to be in Git. You may just fetch and cherry-pick this commit from here: https://github.com/mozilla/gecko-dev/commit/4262e28d067edd239f96cb75a8280b91... Thanks, Jacek
On 12/23/19 12:21 PM, Jacek Caban wrote:
That was from my import, I missed the fact that it's too new to be in Git. You may just fetch and cherry-pick this commit from here:
https://github.com/mozilla/gecko-dev/commit/4262e28d067edd239f96cb75a8280b91...
Pip 8.1.1 is still using the deprecated call. ... 0:03.19$<2> File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/python/virtualenv/virtualenv_support/pip-8.1.1-py2.py3-none-any.whl/pip/download.py", line 93, in user_agent 0:03.19$<2> zip(["name", "version", "id"], platform.linux_distribution()), 0:03.19$<2> AttributeError: module 'platform' has no attribute 'linux_distribution'
Hi Michael, On 23.12.2019 20:28, Michael Cronenworth wrote:
On 12/23/19 12:21 PM, Jacek Caban wrote:
That was from my import, I missed the fact that it's too new to be in Git. You may just fetch and cherry-pick this commit from here:
https://github.com/mozilla/gecko-dev/commit/4262e28d067edd239f96cb75a8280b91...
Pip 8.1.1 is still using the deprecated call.
... 0:03.19$<2> File "/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/python/virtualenv/virtualenv_support/pip-8.1.1-py2.py3-none-any.whl/pip/download.py", line 93, in user_agent 0:03.19$<2> zip(["name", "version", "id"], platform.linux_distribution()), 0:03.19$<2> AttributeError: module 'platform' has no attribute 'linux_distribution'
I just pushed fixes to git. master branch should work with Python 3.8. Please give it a try. Jacek
participants (2)
-
Jacek Caban -
Michael Cronenworth