Re: [PATCH 1/4] ole32: Hold a reference to the stub manager throughout an incoming call.

[Jacek Caban]

Hi Huw,

On 10/13/15 15:49, Huw Davies wrote:
> -HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, IRpcStubBuffer **stub, IRpcChannelBuffer **chan, IID *iid, IUnknown **iface) DECLSPEC_HIDDEN;
> +HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, struct stub_manager **manager, IRpcStubBuffer **stub,
> +                                 IRpcChannelBuffer **chan, IID *iid, IUnknown **iface) DECLSPEC_HIDDEN;

How about returning stub manager instead of APARTMENT? It already
contains APARTMENT reference.

Thanks,
Jacek

[PATCH 1/4] ole32: Hold a reference to the stub manager throughout an incoming call.

[Huw Davies]

On 13 Oct 2015, at 15:24, Jacek Caban wrote:
> On 10/13/15 15:49, Huw Davies wrote:
> > -HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, IRpcStubBuffer **stub, IRpcChannelBuffer **chan, IID *iid, IUnknown **iface) DECLSPEC_HIDDEN;
> > +HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, struct stub_manager **manager, IRpcStubBuffer **stub,
> > +                                 IRpcChannelBuffer **chan, IID *iid, IUnknown **iface) DECLSPEC_HIDDEN;
>
> How about returning stub manager instead of APARTMENT? It already
> contains APARTMENT reference.

Hi Jacek,

The reference is the other way around. The apt holds a
ref on the stub manager (there's a back-ptr to the apt,
but it's not ref counted).

Huw.