Re: imm32: ImmGetCandidateWindow should not return unset data
Aric Stewart <aric(a)codeweavers.com> writes:
@@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) gl->dwSize = sizeof(GUIDELINE); ImmUnlockIMCC(new_context->IMC.hGuideLine);
+ memset(new_context->IMC.cfCandForm, -1, sizeof(new_context->IMC.cfCandForm)); +
That's ugly. If you are using the index for validity checking then you should put some appropriate value in there, there's no reason to put garbage in the whole structure. -- Alexandre Julliard julliard(a)winehq.org
Ok, fixed and resent -aric On 10/1/13 2:13 PM, Alexandre Julliard wrote:
Aric Stewart <aric(a)codeweavers.com> writes:
@@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) gl->dwSize = sizeof(GUIDELINE); ImmUnlockIMCC(new_context->IMC.hGuideLine);
+ memset(new_context->IMC.cfCandForm, -1, sizeof(new_context->IMC.cfCandForm)); +
That's ugly. If you are using the index for validity checking then you should put some appropriate value in there, there's no reason to put garbage in the whole structure.
participants (2)
-
Alexandre Julliard -
Aric Stewart