Re: [3/3] dpnet: Always update Component type since it can change (try 3)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-05 um 09:55 schrieb Alistair Leslie-Hughes:
hr = IDirectPlay8Address_GetComponentByName(localaddr, DPNA_KEY_HOSTNAME, buffer, &size, &type); ok(hr == S_OK, "got 0x%08x\n", hr); - todo_wine ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); + ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); todo_wine ok(!lstrcmpW(buffer, localhost), "Invalid string: %s\n", wine_dbgstr_w(buffer));
I don't understand why the last check still needs todo_wine. Afaics the value should be stored and retrieved correctly. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU+GI4AAoJEN0/YqbEcdMwsyoP/0gkQITbAphMP7a4lonngLNC Bs3N5Pfo+AeXXcBUWMBFWTPfwHlTGxrk6cQZWijDaWI8ahWi57sjTY7iyez9gh7c +mCrewr+vOVOxWT6gIQIvv1xRCOQ2rrDAuNF3Ae9YuwaOvrtVuQmBMZuM5436OrD bTKu4Jj4wwnFRhR9TCQRiReI75vg9ZSF/T+PEnpovRCje7P53FtaqQcAPTDr742O IWSKngP+jAbWn5K4pwxDR8DVgGaGlzWHE7nv0IAZ69hZJy9fovzIGHbyiqQP2bZ6 2elhJkGgeNCwTVxV1ygbheJvs73KBrwf74mJbJUzC98EpdlO87ZJNEJKR6/UzAu5 Gr5aKtlQTjyvzY0AFwiahdWjS+gR5uUJLymAdEHBKjjYZzowzdXNq7KSGluhn5cm /c8EtJxcalix7dTdGp7Jq0te6B0yEk3hcvpYXcyfELo66hW4jdFApFpgZNb1Xx05 pmDfqagqHe3HHma3J4Uxhn0CyxJeOZKdJlQPZldpVia6zlf2y9BjD2iWfXq2Xl1B yoxS/xnmcx1HWvtUDtPmzobNCqZaA5KFNwKCJBGRiD7MaQjeY+EXBz+IjVuSiQk6 HziyqNT5u+CCjRY4MULGC3om4j9qytqxOjbVPKqZPesmYDI0SddrMwWtTcjoSMV8 8G0BUKbyNuBFCe/LiOtM =t8mZ -----END PGP SIGNATURE-----
participants (1)
-
Stefan Dösinger