Re: msi: Reduce destination file name used in the MoveFiles action to the long file name.

[James Hawkins]

On Fri, Sep 5, 2008 at 4:18 PM, Rob Shearman <robertshearman(a)gmail.com> wrote:
> ---
>  dlls/msi/action.c |   22 ++++++++++++++++------
>  1 files changed, 16 insertions(+), 6 deletions(-)
>
> There doesn't appear to be any documentation on MSDN suggesting this
> behaviour but it fixes the following snippet of a log from a
> customised Office 2003 installer:
>
> 0065:trace:msi:msi_move_file copying
> L"C:\\windows\\temp\\~OCW0023.TMP" -> L"C:\\Program Files\\Microsoft
> Office\\sfn|custom11.prf"
> 0065:Call KERNEL32.CopyFileW(0105f4d0
> L"C:\\windows\\temp\\~OCW0023.TMP",0105f1f8 L"C:\\Program
> Files\\Microsoft Office\\sfn|custom11.prf",00000000) ret=7eded205
> 0065:Ret  KERNEL32.CopyFileW() retval=00000000 ret=7eded205
> 0065:warn:msi:msi_move_file CopyFile failed: 123

Can you please add a test case?  The test_movefiles already exists,
and adding this case shouldn't take more than 5 minutes.

-- 
James Hawkins

msi: Reduce destination file name used in the MoveFiles action to the long file name.

[Rob Shearman]

2008/9/5 James Hawkins <truiken(a)gmail.com>:
> Can you please add a test case?  The test_movefiles already exists,
> and adding this case shouldn't take more than 5 minutes.

Sure, no problem.

-- 
Rob Shearman