Re: wintrust/tests: make sure return values are used (LLVM/Clang) (resend)

[Paul Vriens]

On 02/04/2011 09:32 AM, Austin English wrote:
> -            ret = funcs->pfnObjectTrust(&data);
> +            funcs->pfnObjectTrust(&data);
> +            ok(ret == S_FALSE, "Expected S_FALSE, got %08x\n", ret);

This doesn't look correct (you are removing the assignment and then 
check it). I know that this code path will never be taken, but still.

-- 
Cheers,

Paul.

wintrust/tests: make sure return values are used (LLVM/Clang) (resend)

[Austin English]

On Fri, Feb 4, 2011 at 00:42, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> On 02/04/2011 09:32 AM, Austin English wrote:
> > -            ret = funcs->pfnObjectTrust(&data);
> > +            funcs->pfnObjectTrust(&data);
> > +            ok(ret == S_FALSE, "Expected S_FALSE, got %08x\n", ret);
>
> This doesn't look correct (you are removing the assignment and then check
> it). I know that this code path will never be taken, but still.

Fixed, thanks.

Bedtime now, before I make any more typos :-).

-- 
-Austin