Re: [PATCH 4/5] atl100: Implemented semi stub AtlAxCreateControlLic and AtlAxCreateControlLicEx.

[Jacek Caban]

Hi Qian,

On 01/23/15 10:19, Qian Hong wrote:
> diff --git a/dlls/atl/atl_ax.c b/dlls/atl/atl_ax.c
> index 15b0550..656165b 100644
> --- a/dlls/atl/atl_ax.c
> +++ b/dlls/atl/atl_ax.c
> @@ -1435,8 +1435,9 @@ INT_PTR WINAPI AtlAxDialogBoxA(HINSTANCE hInstance, LPCSTR lpTemplateName, HWND
>   */
>  HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, IUnknown **container, BSTR lic)
>  {
> -    FIXME("(%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic));
> -    return E_NOTIMPL;
> +    if (lic)
> +        FIXME("semi stub (%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic));
> +    return AtlAxCreateControl(lpTricsData, hwnd, stream, container);
>  }
>
> /***********************************************************************
> @@ -1446,9 +1447,10 @@ HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStrea
>  HRESULT WINAPI AtlAxCreateControlLicEx(const WCHAR *lpTricsData, HWND hwnd, IStream *stream,
>          IUnknown **container, IUnknown **control, REFIID iidSink, IUnknown *punkSink, BSTR lic)
>  {
> -    FIXME("(%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control,
> +    if (lic)
> +        FIXME("semi stub (%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control,
>            debugstr_guid(iidSink), punkSink, debugstr_w(lic));
> -    return E_NOTIMPL;
> +    return AtlAxCreateControlEx(lpTricsData, hwnd, stream, container, control, iidSink, punkSink);
>  }
>
> #endif

Please forward AtlAxCreateControlEx to AtlAxCreateControlLicEx and add
FIXME about unsupported argument instead of the other way around.
Otherwise we'd have to do that later to support the argument anyway.

Also AtlAxCreateControlLic would probably be better forwarded to
AtlAxCreateControlLicEx.

Cheers,
Jacek

[PATCH 4/5] atl100: Implemented semi stub AtlAxCreateControlLic and AtlAxCreateControlLicEx.

[Qian Hong]

Hi Jacek,

On Fri, Jan 23, 2015 at 6:11 PM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> Please forward AtlAxCreateControlEx to AtlAxCreateControlLicEx and add
> FIXME about unsupported argument instead of the other way around.
> Otherwise we'd have to do that later to support the argument anyway.
>
> Also AtlAxCreateControlLic would probably be better forwarded to
> AtlAxCreateControlLicEx.

Good point, thanks for advice.
Also thanks for the new line catch :)


-- 
Regards,
Qian Hong

-
http://www.codeweavers.com