Re: [PATCH] advapi32: Eliminate dead stores (Clang).

[Alexandre Julliard]

Charles Davis <cdavis5x(a)gmail.com> writes:
> @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b
>          attr_list.count = 0;
>          attr_list.attr = NULL;
>      }
> -    status = SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list,
> -                                                    preserve_blob ? 0 : strlen(password),
> -                                                    preserve_blob ? NULL : password);
> +    SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list,
> +                                           preserve_blob ? 0 : strlen(password),
> +                                           preserve_blob ? NULL : password);

I expect you'd want to handle that error instead.

-- 
Alexandre Julliard
julliard(a)winehq.org