RE: fix brainfade

[Medland, Bill]

Alexandre

Yes, go with Francois'

Bill
> -----Original Message-----
> From: Francois Gouget [mailto:fgouget(a)free.fr]
> Sent: Wednesday, May 01, 2002 3:27 PM
> To: Wine patches (E-mail)
> Subject: Re: fix brainfade
>
> Or (but mine may have space/tab problems):
>
> Index: wine/dlls/comctl32/status.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/comctl32/status.c,v
> retrieving revision 1.43
> diff -u -r1.43 status.c
> --- wine/dlls/comctl32/status.c 29 Apr 2002 17:12:01 -0000      1.43
> +++ wine/dlls/comctl32/status.c 1 May 2002 21:03:46 -0000
> @@ -636,7 +636,7 @@
>      if (nPart == 0x00ff) {
>         part = &infoPtr->part0;
>      } else {
> -       if (infoPtr->parts && (nPart < 0 || nPart >= 
> infoPtr->numParts)) {
> +       if (infoPtr->parts && nPart >= 0 && nPart < 
> infoPtr->numParts)) {
>             part = &infoPtr->parts[nPart];
>         }
>      }
>
> --
> Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
>  The greatest programming project of all took six days; on 
> the seventh day the
>   programmer rested. We've been trying to debug the *&^%$#@ 
> thing ever since.
>                       Moral: design before you implement.

fix brainfade

[Dustin Navea]

-       if (infoPtr->parts && (nPart < 0 || nPart >=
infoPtr->numParts)) {
+       if (infoPtr->parts && nPart >= 0 && nPart <
infoPtr->numParts)) {

i noticed one problem with the changed line above:

+       if (infoPtr->parts && nPart >= 0 && nPart <
infoPtr->numParts)) {
                 ^

there is one too many closing parenthesis, so if
someone wants to change that before the next snapshot,
please....

-Dustin

__________________________________________________
Do You Yahoo!?
Yahoo! Health - your guide to health and wellness
http://health.yahoo.com

fix brainfade

[Francois Gouget]

On Fri, 3 May 2002, Dustin Navea wrote:
> -       if (infoPtr->parts && (nPart < 0 || nPart >=
> infoPtr->numParts)) {
> +       if (infoPtr->parts && nPart >= 0 && nPart <
> infoPtr->numParts)) {
>
> i noticed one problem with the changed line above:
>
> +       if (infoPtr->parts && nPart >= 0 && nPart <
> infoPtr->numParts)) {
>                  ^
>
> there is one too many closing parenthesis, so if
> someone wants to change that before the next snapshot,
> please....

He, he. My turn to make a dumb error. But we'll get that code right. It
will just take 3 or 4 more iterations :-)


--
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
                  In a world without fences who needs Gates?