Re: gdiplus: skip some tests if Arial is not installed

[Dmitry Timoshkov]

Austin English <austinenglish(a)gmail.com> wrote:
> +    status = GdipCreateFontFamilyFromName(Arial, NULL, &family);
> +    if (status == FontFamilyNotFound)
> +    {
> +        skip("Arial not installed\n");
> +        return;
> +    }

Why do you need this? This test doesn't depend on Arial font presence.

-- 
Dmitry.

gdiplus: skip some tests if Arial is not installed

[Austin English]

On Sat, Mar 22, 2014 at 6:09 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> Austin English <austinenglish(a)gmail.com> wrote:
> > +    status = GdipCreateFontFamilyFromName(Arial, NULL, &family);
> > +    if (status == FontFamilyNotFound)
> > +    {
> > +        skip("Arial not installed\n");
> > +        return;
> > +    }
>
> Why do you need this? This test doesn't depend on Arial font presence.
>
> --
> Dmitry.

dlls/gdiplus/tests/font.c

font.c:784<https://source.winehq.org/git/wine.git/?a=blob;f=dlls/gdiplus/tests/font.c;hb=3ea505bdea39d9c412120d6120c39067170cabc7#l784>:
Test failed: wrong face name Liberation Sans
font.c:794<https://source.winehq.org/git/wine.git/?a=blob;f=dlls/gdiplus/tests/font.c;hb=3ea505bdea39d9c412120d6120c39067170cabc7#l794>:
Test failed: wrong face name Liberation Sans

784 ok(!lstrcmpA(lf.lfFaceName, "Arial"), "wrong face name %s\n",
lf.lfFaceName);
...
794 ok(!lstrcmpA(lf.lfFaceName, "Arial"), "wrong face name %s\n",
lf.lfFaceName);

-- 
-Austin

gdiplus: skip some tests if Arial is not installed

[Dmitry Timoshkov]

Austin English <austinenglish(a)gmail.com> wrote:
> font.c:784<https://source.winehq.org/git/wine.git/?a=blob;f=dlls/gdiplus/tests/font.c;hb=3ea505bdea39d9c412120d6120c39067170cabc7#l784>:
> Test failed: wrong face name Liberation Sans
> font.c:794<https://source.winehq.org/git/wine.git/?a=blob;f=dlls/gdiplus/tests/font.c;hb=3ea505bdea39d9c412120d6120c39067170cabc7#l794>:
> Test failed: wrong face name Liberation Sans
>
> 784 ok(!lstrcmpA(lf.lfFaceName, "Arial"), "wrong face name %s\n",
> lf.lfFaceName);
> ...
> 794 ok(!lstrcmpA(lf.lfFaceName, "Arial"), "wrong face name %s\n",
> lf.lfFaceName);

That's a gdi32 breakage (it shouldn't return "Liberation Sans"), nothing
to do with gdiplus tests.

-- 
Dmitry.