Re: [PATCH] [WinHelp]: fix for 5314

[Dmitry Timoshkov]

From: "Eric Pouech" <eric.pouech(a)orange.fr> wrote:
> +#include <ctype.h>
> ...
> +                if (!ch || !isalpha(ch)) break;

Since that's apparently a Windows encoding shouldn't this be
GetStringType() instead of isalpha()?

-- 
Dmitry.

[PATCH] [WinHelp]: fix for 5314

[Eric Pouech]

Dmitry Timoshkov a écrit :
> From: "Eric Pouech" <eric.pouech(a)orange.fr> wrote:
> > +#include <ctype.h>
>
> ...
> > +                if (!ch || !isalpha(ch)) break;
>
> Since that's apparently a Windows encoding shouldn't this be
> GetStringType() instead of isalpha()?

no, the issue (here) is about creeping control characters in the string 
(which shows a bogus file, not a mishandling of encoding)
and also, it appears that the string is 7bit ascii, so isalpha is sufficient
A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)