Re: [PATCH] Get the position from the driver on every GetCursorPos run

[Alexandre Julliard]

Max Qian <public(a)maxqia.com> writes:
> This reverts the GetCursorPos changes in commits 6576703 and f1a3480 to fix bug 24951.

This is going to reintroduce the performance issues that the changes
were supposed to fix. Doing a server round-trip on every GetCursorPos
gives bad results in many apps. You'll need to find a fix that doesn't
require this.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] Get the position from the driver on every GetCursorPos run

[Max Qian]

On 2016-08-22 10:15 pm, Alexandre Julliard wrote:
> Max Qian <public(a)maxqia.com> writes:
> > This reverts the GetCursorPos changes in commits 6576703 and f1a3480 
> > to fix bug 24951.
>
> This is going to reintroduce the performance issues that the changes
> were supposed to fix. Doing a server round-trip on every GetCursorPos
> gives bad results in many apps. You'll need to find a fix that doesn't
> require this.
> Aren't we currently doing a server round-trip on every GetCursorPos? 
> Also what are some of the apps that experience this?

[PATCH] Get the position from the driver on every GetCursorPos run

[Alexandre Julliard]

Max Qian <public(a)maxqia.com> writes:
> On 2016-08-22 10:15 pm, Alexandre Julliard wrote:
> > Max Qian <public(a)maxqia.com> writes:
> > > This reverts the GetCursorPos changes in commits 6576703 and
> > > f1a3480 to fix bug 24951.
> >
> > This is going to reintroduce the performance issues that the changes
> > were supposed to fix. Doing a server round-trip on every GetCursorPos
> > gives bad results in many apps. You'll need to find a fix that doesn't
> > require this.
> > Aren't we currently doing a server round-trip on every GetCursorPos?

Yes, but that doesn't seem to hurt as much. Of course doing both is much
worse...
> Also what are some of the apps that experience this?

I think it was mostly games using dinput for mouse events.

-- 
Alexandre Julliard
julliard(a)winehq.org