Can't compile wine-git: initializer element is not constant in d3d11

[Bruno Jesus]

Hi all, I have not compiled wine in one about 4 days and now I updated
and tried and the results are:

../../../wine/dlls/d3d11/utils.c: In function
‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
../../../wine/dlls/d3d11/utils.c:473:13: error: initializer element is
not constant
../../../wine/dlls/d3d11/utils.c: In function
‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
../../../wine/dlls/d3d11/utils.c:501:13: error: initializer element is
not constant
make[1]: ** [utils.o] Erro 1
make[1]: Saindo do diretório `/home/bruno/programs/wine32/dlls/d3d11'
make: ** [dlls/d3d11] Erro 2

Is anyone experiencing a similar issue? I already tried make clean && make.

Best regards,
Bruno

[Zhenbo Li]

I ran a bisect on this, and found a bad commit

Wine build complete.
1c643f39e2814dca59e284092aa3fb47f6280791 is the first bad commit
commit 1c643f39e2814dca59e284092aa3fb47f6280791
Author: Andrew Eikum <aeikum(a)codeweavers.com>
Date:   Tue Aug 25 14:28:37 2015 -0500

    xaudio2: Implement device activation.

    This adds a build-time dependency on openal, and a run-time dependency
    on openal-soft's ALC_SOFT_loopback extension.

:100755 100755 4f71ac375a2dce845be90c77fcde83b2bfa64c79
afa7bb4472c8bf4cf8d15ffacc592a02612ace19 M      configure
:100644 100644 e0376882873267affce0907ac974b3e92251693a
b59261551ca36005720b5504e8f0031d94aef96d M      configure.ac
:040000 040000 1c7b486e4103008fa1a74f165ffbefbab1c416e2
77e0f0306d3310134b4f3b1a27704f84d0170cd6 M      dlls

More details in
[PATCH 1/4] xaudio2: Implement device activation
http://wine.1045685.n5.nabble.com/Re-PATCH-1-4-xaudio2-Implement-device-acti...

2015-08-29 9:18 GMT+08:00 Bruno Jesus <00cpxxx(a)gmail.com>:
> Hi all, I have not compiled wine in one about 4 days and now I updated
> and tried and the results are:
>
> ../../../wine/dlls/d3d11/utils.c: In function
> ‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
> ../../../wine/dlls/d3d11/utils.c:473:13: error: initializer element is
> not constant
> ../../../wine/dlls/d3d11/utils.c: In function
> ‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
> ../../../wine/dlls/d3d11/utils.c:501:13: error: initializer element is
> not constant
> make[1]: ** [utils.o] Erro 1
> make[1]: Saindo do diretório `/home/bruno/programs/wine32/dlls/d3d11'
> make: ** [dlls/d3d11] Erro 2
>
> Is anyone experiencing a similar issue? I already tried make clean && make.
>
> Best regards,
> Bruno

-- 
Have a nice day!
Zhenbo Li

[Bruno Jesus]

On Saturday, August 29, 2015, Zhenbo Li <litimetal(a)gmail.com> wrote:
> I ran a bisect on this, and found a bad commit
>
> Wine build complete.
> 1c643f39e2814dca59e284092aa3fb47f6280791 is the first bad commit
> commit 1c643f39e2814dca59e284092aa3fb47f6280791
> Author: Andrew Eikum <aeikum(a)codeweavers.com <javascript:;>>
> Date:   Tue Aug 25 14:28:37 2015 -0500
>
> xaudio2: Implement device activation.
>
> This adds a build-time dependency on openal, and a run-time dependency
>     on openal-soft's ALC_SOFT_loopback extension.
>
> :100755 100755 4f71ac375a2dce845be90c77fcde83b2bfa64c79
> afa7bb4472c8bf4cf8d15ffacc592a02612ace19 M      configure
> :100644 100644 e0376882873267affce0907ac974b3e92251693a
> b59261551ca36005720b5504e8f0031d94aef96d M      configure.ac
> :040000 040000 1c7b486e4103008fa1a74f165ffbefbab1c416e2
> 77e0f0306d3310134b4f3b1a27704f84d0170cd6 M      dlls
>
> More details in
> [PATCH 1/4] xaudio2: Implement device activation
>
> http://wine.1045685.n5.nabble.com/Re-PATCH-1-4-xaudio2-Implement-device-acti...

Hi, thanks for helping but I think you actually found the same as bug
https://bugs.winehq.org/show_bug.cgi?id=39165 which is a different issue :-)

[Józef Kucia]

Thanks for finding this issue. The attached diff should fix
compilation for you. What compiler do you use?

On Sat, Aug 29, 2015 at 3:18 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
> Hi all, I have not compiled wine in one about 4 days and now I updated
> and tried and the results are:
>
> ../../../wine/dlls/d3d11/utils.c: In function
> ‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
> ../../../wine/dlls/d3d11/utils.c:473:13: error: initializer element is
> not constant
> ../../../wine/dlls/d3d11/utils.c: In function
> ‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
> ../../../wine/dlls/d3d11/utils.c:501:13: error: initializer element is
> not constant
> make[1]: ** [utils.o] Erro 1
> make[1]: Saindo do diretório `/home/bruno/programs/wine32/dlls/d3d11'
> make: ** [dlls/d3d11] Erro 2
>
> Is anyone experiencing a similar issue? I already tried make clean && make.
>
> Best regards,
> Bruno

[André Hentschel]

Am 29.08.2015 um 06:59 schrieb Józef Kucia:
> Thanks for finding this issue. The attached diff should fix
> compilation for you. What compiler do you use?
>
> On Sat, Aug 29, 2015 at 3:18 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
> > Hi all, I have not compiled wine in one about 4 days and now I updated
> > and tried and the results are:
> >
> > ../../../wine/dlls/d3d11/utils.c: In function
> > ‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
> > ../../../wine/dlls/d3d11/utils.c:473:13: error: initializer element is
> > not constant
> > ../../../wine/dlls/d3d11/utils.c: In function
> > ‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
> > ../../../wine/dlls/d3d11/utils.c:501:13: error: initializer element is
> > not constant
> > make[1]: ** [utils.o] Erro 1
> > make[1]: Saindo do diretório `/home/bruno/programs/wine32/dlls/d3d11'
> > make: ** [dlls/d3d11] Erro 2
> >
> > Is anyone experiencing a similar issue? I already tried make clean && make.
> >
> > Best regards,
> > Bruno

That patch seems not to be enough:

arm-linux-gnueabihf-gcc -c -o utils.o ../../../dlls/d3d11/utils.c -I. -I../../../dlls/d3d11 -I../../include \
  -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing \
  -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -march=armv7-a -marm
../../../dlls/d3d11/utils.c: In function ‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
../../../dlls/d3d11/utils.c:473:13: error: initializer element is not constant
             | D3D10_RESOURCE_MISC_GDI_COMPATIBLE;
             ^
../../../dlls/d3d11/utils.c: In function ‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
../../../dlls/d3d11/utils.c:501:13: error: initializer element is not constant
             | D3D11_RESOURCE_MISC_GDI_COMPATIBLE;
             ^

[André Hentschel]

Am 29.08.2015 um 14:31 schrieb André Hentschel:
> Am 29.08.2015 um 06:59 schrieb Józef Kucia:
> > Thanks for finding this issue. The attached diff should fix
> > compilation for you. What compiler do you use?
> >
> > On Sat, Aug 29, 2015 at 3:18 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
> > > Hi all, I have not compiled wine in one about 4 days and now I updated
> > > and tried and the results are:
> > >
> > > ../../../wine/dlls/d3d11/utils.c: In function
> > > ‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
> > > ../../../wine/dlls/d3d11/utils.c:473:13: error: initializer element is
> > > not constant
> > > ../../../wine/dlls/d3d11/utils.c: In function
> > > ‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
> > > ../../../wine/dlls/d3d11/utils.c:501:13: error: initializer element is
> > > not constant
> > > make[1]: ** [utils.o] Erro 1
> > > make[1]: Saindo do diretório `/home/bruno/programs/wine32/dlls/d3d11'
> > > make: ** [dlls/d3d11] Erro 2
> > >
> > > Is anyone experiencing a similar issue? I already tried make clean && make.
> > >
> > > Best regards,
> > > Bruno
>
> That patch seems not to be enough:
>
> arm-linux-gnueabihf-gcc -c -o utils.o ../../../dlls/d3d11/utils.c -I. -I../../../dlls/d3d11 -I../../include \
>   -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing \
>   -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits \
>   -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -march=armv7-a -marm
> ../../../dlls/d3d11/utils.c: In function ‘d3d11_resource_misc_flags_from_d3d10_resource_misc_flags’:
> ../../../dlls/d3d11/utils.c:473:13: error: initializer element is not constant
>              | D3D10_RESOURCE_MISC_GDI_COMPATIBLE;
>              ^
> ../../../dlls/d3d11/utils.c: In function ‘d3d10_resource_misc_flags_from_d3d11_resource_misc_flags’:
> ../../../dlls/d3d11/utils.c:501:13: error: initializer element is not constant
>              | D3D11_RESOURCE_MISC_GDI_COMPATIBLE;
>              ^

Sorry for the noise, the patch wasn't applied correctly *facepalm*

[Bruno Jesus]

On Sat, Aug 29, 2015 at 12:59 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
> Thanks for finding this issue. The attached diff should fix
> compilation for you. What compiler do you use?

As André already told the patch does work, thanks. I could not test
earlier because only now I had time to use the computer. My compiler
is:
gcc-4.6 (Debian 4.6.4-4) 4.6.4

[Marcus Meissner]

On Sat, Aug 29, 2015 at 10:19:53PM +0800, Bruno Jesus wrote:
> On Sat, Aug 29, 2015 at 12:59 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
> > Thanks for finding this issue. The attached diff should fix
> > compilation for you. What compiler do you use?
>
> As André already told the patch does work, thanks. I could not test
> earlier because only now I had time to use the computer. My compiler
> is:
> gcc-4.6 (Debian 4.6.4-4) 4.6.4

Please dont just build with -O0?

Ciao, Marcus

[Zhenbo Li]

2015-08-31 6:47 GMT+08:00 Marcus Meissner <marcus(a)jet.franken.de>:
> Please dont just build with -O0?

Thanks, Marcus
With -O1 instead of -O0, the code can be compiled.
I hope that patch 114091 can be committed soon.

-- 
Have a nice day!
Zhenbo Li