Re: [PATCH 2/3] comctl32/propsheet: Implement PSM_SETHEADERTITLE
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
case PSM_SETHEADERTITLEW: - PROPSHEET_SetHeaderTitleW(hwnd, (int)wParam, (LPCWSTR)lParam); - return TRUE; + PROPSHEET_SetHeaderTitleW(hwnd, wParam, (LPCWSTR)lParam); + return FALSE;
case PSM_SETHEADERTITLEA: - PROPSHEET_SetHeaderTitleA(hwnd, (int)wParam, (LPCSTR)lParam); - return TRUE; + PROPSHEET_SetHeaderTitleA(hwnd, wParam, (LPCSTR)lParam); + return FALSE;
Not that it makes much difference, but is there a reason for changing these to returning FALSE? -- Alexandre Julliard julliard(a)winehq.org
On 02/16/2017 09:06 PM, Alexandre Julliard wrote:
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
case PSM_SETHEADERTITLEW: - PROPSHEET_SetHeaderTitleW(hwnd, (int)wParam, (LPCWSTR)lParam); - return TRUE; + PROPSHEET_SetHeaderTitleW(hwnd, wParam, (LPCWSTR)lParam); + return FALSE;
case PSM_SETHEADERTITLEA: - PROPSHEET_SetHeaderTitleA(hwnd, (int)wParam, (LPCSTR)lParam); - return TRUE; + PROPSHEET_SetHeaderTitleA(hwnd, wParam, (LPCSTR)lParam); + return FALSE;
Not that it makes much difference, but is there a reason for changing these to returning FALSE?
I tested this manually, sending to propsheet window always returns 0 for these messages. I guess I missed the fact that it's a dialog procedure, is that what you mean?
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
On 02/16/2017 09:06 PM, Alexandre Julliard wrote:
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
case PSM_SETHEADERTITLEW: - PROPSHEET_SetHeaderTitleW(hwnd, (int)wParam, (LPCWSTR)lParam); - return TRUE; + PROPSHEET_SetHeaderTitleW(hwnd, wParam, (LPCWSTR)lParam); + return FALSE; case PSM_SETHEADERTITLEA: - PROPSHEET_SetHeaderTitleA(hwnd, (int)wParam, (LPCSTR)lParam); - return TRUE; + PROPSHEET_SetHeaderTitleA(hwnd, wParam, (LPCSTR)lParam); + return FALSE;
Not that it makes much difference, but is there a reason for changing these to returning FALSE?
I tested this manually, sending to propsheet window always returns 0 for these messages. I guess I missed the fact that it's a dialog procedure, is that what you mean?
Yes, the meaning is different for dialog procedures. The window procedure will end up returning 0 in both cases, but TRUE is better when the message has been handled. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Nikolay Sivov