Missed patches concerning valgrind-detected issues

[Kirill K. Smirnov]

Hello, Alexandre,

Is there anything wrong with this couple of patches:

dsound: check error status of waveOutGetVolume() function before using 
retrieved values (found by valgrind)
http://www.winehq.org/pipermail/wine-patches/2008-July/058124.html

and

cmd: Do not deceive CompareString() passing more characters then we really 
have (found by valgrind)
http://www.winehq.org/pipermail/wine-patches/2008-July/058504.html

Thanks
--
Kirill

[Alexandre Julliard]

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes:
> Hello, Alexandre,
>
> Is there anything wrong with this couple of patches:
>
> dsound: check error status of waveOutGetVolume() function before using 
> retrieved values (found by valgrind)
> http://www.winehq.org/pipermail/wine-patches/2008-July/058124.html

You should most likely propagate the errors instead of assuming default
values.
> cmd: Do not deceive CompareString() passing more characters then we really 
> have (found by valgrind)
> http://www.winehq.org/pipermail/wine-patches/2008-July/058504.html

There shouldn't be any need to pass an explicit length here, the code is
confused.

-- 
Alexandre Julliard
julliard(a)winehq.org