Re: Regression errors

[Gerard Patel]

At 11:06 AM 10/11/2001 -0500, you wrote:
> Thanks Gerard. I will try it Tuesday. Going out of town till then.

Well, I have advanced a bit this weekend. I noticed that one of my
test app does indeed show this regression after the patch we are talking
about.

As the case is a lot more simple than the one I was trying to debug 
before for this problem, I have been able to understand better what
is happening. The problem shows itself in the following case :

- invalidating a window
- hiding it
- deleting it

and after that the paint count is > 0.

I can make the paint count change correctly with the following change :

--- winpos.c.orig       Thu Nov  8 01:57:34 2001
+++ winpos.c    Mon Nov 12 09:47:08 2001
@@ -883,10 +883,10 @@
 
         if (!(winpos->flags & SWP_SHOWWINDOW) && (winpos->flags &
SWP_HIDEWINDOW))
         {
-            WIN_SetStyle( winpos->hwnd, wndPtr->dwStyle & ~WS_VISIBLE );
             /* clear the update region */
-//            RedrawWindow( winpos->hwnd, NULL, 0, RDW_VALIDATE | RDW_NOFRAME |
-//                          RDW_NOERASE | RDW_NOINTERNALPAINT |
RDW_ALLCHILDREN );
+            RedrawWindow( winpos->hwnd, NULL, 0, RDW_VALIDATE | RDW_NOFRAME |
+                          RDW_NOERASE | RDW_NOINTERNALPAINT |
RDW_ALLCHILDREN );
+            WIN_SetStyle( winpos->hwnd, wndPtr->dwStyle & ~WS_VISIBLE );
         }
         else if ((wndPtr->dwStyle & WS_VISIBLE) &&
                  !IsRectEmpty( &oldWindowRect ) && IsRectEmpty(
&newWindowRect ))

Now, I don't know why this RedrawWindow call was commented out :-/

Gerard

Regression errors

[Guy L. Albertelli]

----- Original Message -----
From: "Gerard Patel" <gerard.patel(a)nerim.net>
To: "Guy L. Albertelli" <galberte(a)neo.lrun.com>
Cc: <wine-devel(a)winehq.com>
Sent: Monday, November 12, 2001 5:03 AM
Subject: Re: Regression errors
> At 11:06 AM 10/11/2001 -0500, you wrote:
> > Thanks Gerard. I will try it Tuesday. Going out of town till then.
>
> Well, I have advanced a bit this weekend. I noticed that one of my
> test app does indeed show this regression after the patch we are talking
> about.
>
> As the case is a lot more simple than the one I was trying to debug
> before for this problem, I have been able to understand better what
> is happening. The problem shows itself in the following case :
>
> - invalidating a window
> - hiding it
> - deleting it
>
> and after that the paint count is > 0.
>
> I can make the paint count change correctly with the following change :

<snip>

That patch fixes the hangs I was having. Thanks a lot. I think you should
submit it.

Guy