Re: Alexandre Julliard : wintab32: Make a function static.

[Francois Gouget]

On Thu, 4 Dec 2008, Alexandre Julliard wrote:
[...]
> -UINT WINAPI WTInfoT(UINT wCategory, UINT nIndex, LPVOID lpOutput, BOOL bUnicode)
> +static UINT WTInfoT(UINT wCategory, UINT nIndex, LPVOID lpOutput, BOOL bUnicode)

So how do you know which functions to make static? I guess you don't 
just mark them all static and see if it causes compilation errors.

Is it a script parsing the 'nm -D' output and then grepping for them in 
the spec file and in object files? I guess there's better way.

Is it something that can be automated? I'm thinking either patchwatcher 
or my weekly scripts here.


-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
                      Computers are like airconditioners
                They stop working properly if you open WINDOWS

Alexandre Julliard : wintab32: Make a function static.

[Alexandre Julliard]

Francois Gouget <fgouget(a)free.fr> writes:
> So how do you know which functions to make static? I guess you don't 
> just mark them all static and see if it causes compilation errors.
>
> Is it a script parsing the 'nm -D' output and then grepping for them in 
> the spec file and in object files? I guess there's better way.

Currently I'm doing basically nm -D and then grep *.spec *.c. There are
a number of false positives since it will miss macros etc. so it's
probably a bit hard to automate. I suppose you could keep a current list
and then check for new symbols once a week.

-- 
Alexandre Julliard
julliard(a)winehq.org