Question about recommended clang option

[Dean Greer]

Hi all,

I know
https://wiki.winehq.org/Clang hasn’t been updated in forever so I’m
wondering is it still recommended to to set CFLAGS=“-std=gnu89”

I’m asking as I’m able to compile using clang with and without this option
for both wine-devel and wine-staging, so is this really require or any
drawbacks to using or not using this option?

[Francois Gouget]

On Fri, 5 Mar 2021, Dean Greer wrote:
> Hi all,
>
> I know
> https://wiki.winehq.org/Clang hasn’t been updated in forever so I’m
> wondering is it still recommended to to set CFLAGS=“-std=gnu89”
>
> I’m asking as I’m able to compile using clang with and without this option
> for both wine-devel and wine-staging, so is this really require or any
> drawbacks to using or not using this option?

At some point the policy was to stick to C89. So I think the main reason 
for this recommendation is that when compiling without gnu89 you would 
risk unintentionally sending patches that would then be rejected on that 
ground.

I'm not 100% sure if the C89 policy is still in effect but I believe it 
to be the case.

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
          tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY