Re: [PATCH] user32: Removed 16-bit windows position trunc in WINPOS_SetPlacement.
Kees Beets <kbeets68(a)gmail.com> writes:
Fixes https://bugs.winehq.org/show_bug.cgi?id=38231
Replaced SetWindowPos in WINPOS_SetPlacement with an implementation that does not truncate windows positions to 16-bit. Fixes a bug in Adobe Lightroom under wine that is not present under windows (7, 8, 10), while still running all win tests successfully.
It's good that it doesn't break the other tests, but since we currently don't have tests for SetWindowPlacement, that's not very convincing. You'd want to add some tests at least for the truncation thing, and also probably some for the message sequences. -- Alexandre Julliard julliard(a)winehq.org
Locally I've added a simple test to tests/win.c for SetWindowPlacement. It runs fine without my patch, it fails on the truncation thingie with patch -but- it also fails, and in the same way, when I run it on Windows itself (make crosstest and then on Win10 / HP Zbook). I'm not that familiar with wine/windows development so it may take me some time to figure this out and submit something worthwhile reviewing, but I won't give up :). On 05/05/2017 10:13 AM, Alexandre Julliard wrote:
Kees Beets <kbeets68(a)gmail.com> writes:
Fixes https://bugs.winehq.org/show_bug.cgi?id=38231
Replaced SetWindowPos in WINPOS_SetPlacement with an implementation that does not truncate windows positions to 16-bit. Fixes a bug in Adobe Lightroom under wine that is not present under windows (7, 8, 10), while still running all win tests successfully. It's good that it doesn't break the other tests, but since we currently don't have tests for SetWindowPlacement, that's not very convincing. You'd want to add some tests at least for the truncation thing, and also probably some for the message sequences.
participants (2)
-
Alexandre Julliard -
Kees Beets