Re: x11drv: Escape international characters
"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote:
It seems better to represent international characters with escape sequences, both to increase clarity - especially for those who do not normally use ISO-8859-1 encoding - and to make editing easier for some.
Please don't do that. Anyone who wants to edit keyboard tables should set editor to ISO-8859-1 encoding. Otherwise it becomes really hard to add new tables or fix existing ones by just comparing or even copy/pasting from the +key log. -- Dmitry.
Dmitry Timoshkov wrote:
"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote:
It seems better to represent international characters with escape sequences, both to increase clarity - especially for those who do not normally use ISO-8859-1 encoding - and to make editing easier for some.
Please don't do that. Anyone who wants to edit keyboard tables should set editor to ISO-8859-1 encoding. Otherwise it becomes really hard to add new tables or fix existing ones by just comparing or even copy/pasting from the +key log.
Hi Dmitry, I am very happy not to spoil anyone's day. :) I have followed my patch submission with your objection on wine-patches. -- Andy.
Hi, On Fri, Jun 16, 2006 at 11:46:02PM +0900, Dmitry Timoshkov wrote:
"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote:
It seems better to represent international characters with escape sequences, both to increase clarity - especially for those who do not normally use ISO-8859-1 encoding - and to make editing easier for some.
Please don't do that. Anyone who wants to edit keyboard tables should set editor to ISO-8859-1 encoding. Otherwise it becomes really hard to add new tables or fix existing ones by just comparing or even copy/pasting from the +key log.
So? Then why don't I see a *very prominent* notice in this file that tells me to do just that whenever I plan to submit a patch? ;) Could you perhaps add that if possible? (I don't have a current Wine tree here right now, sorry) Andreas
participants (3)
-
Andreas Mohr -
Andrew Talbot -
Dmitry Timoshkov