RE: [PATCH] xinput1_3: Prefer builtin DLL

[Filip Frackiewicz]

Hi Bruno,

I hope I am not intruding or stating something already known,,,
> -    case DLL_WINE_PREATTACH:
> -        return FALSE; /* prefer native version */
>      case DLL_PROCESS_ATTACH:
>          DisableThreadLibraryCalls(inst);
>          break;

This code looks different than the patch
https://bugs.winehq.org/attachment.cgi?id=55851 attached to
https://bugs.winehq.org/show_bug.cgi?id=41428

The patch attached to the bug did fix the issue in another game for me.

Just thought I'd mention this just in case :)

Cheers,

Filip

[PATCH] xinput1_3: Prefer builtin DLL

[Bruno Jesus]

On Sun, Oct 30, 2016 at 12:37 PM, Filip Frackiewicz
<fjfrackiewicz(a)gmail.com> wrote:
> Hi Bruno,

Hello, thanks for the email.
> I hope I am not intruding or stating something already known,,,
> > -    case DLL_WINE_PREATTACH:
> > -        return FALSE; /* prefer native version */
> >      case DLL_PROCESS_ATTACH:
> >          DisableThreadLibraryCalls(inst);
> >          break;
>
> This code looks different than the patch
> https://bugs.winehq.org/attachment.cgi?id=55851 attached to
> https://bugs.winehq.org/show_bug.cgi?id=41428

If you take a look at the whole function [1] you will see that it
returns TRUE in the end, so there is no need for the "case
DLL_WINE_PREATTACH" any longer.

[1] http://source.winehq.org/source/dlls/xinput1_3/xinput1_3_main.c#0042

[PATCH] xinput1_3: Prefer builtin DLL

[Filip Frackiewicz]

Ahh I see what you mean now, thank you for clarifying :)

Filip

On Sun, Oct 30, 2016 at 4:04 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
> On Sun, Oct 30, 2016 at 12:37 PM, Filip Frackiewicz
> <fjfrackiewicz(a)gmail.com> wrote:
> > Hi Bruno,
>
> Hello, thanks for the email.
> > I hope I am not intruding or stating something already known,,,
> > > -    case DLL_WINE_PREATTACH:
> > > -        return FALSE; /* prefer native version */
> > >      case DLL_PROCESS_ATTACH:
> > >          DisableThreadLibraryCalls(inst);
> > >          break;
> >
> > This code looks different than the patch
> > https://bugs.winehq.org/attachment.cgi?id=55851 attached to
> > https://bugs.winehq.org/show_bug.cgi?id=41428
>
> If you take a look at the whole function [1] you will see that it
> returns TRUE in the end, so there is no need for the "case
> DLL_WINE_PREATTACH" any longer.
>
> [1] http://source.winehq.org/source/dlls/xinput1_3/xinput1_3_main.c#0042