Re: oleaut32: preliminary support for VT_DISPATCH as parameters to VarAdd (and other 2-operand operations) (try 3)
26 Dec
2006
26 Dec
'06
12:45 p.m.
a_villacis(a)palosanto.com writes:
This is another attempt to add IDispatch support to several 2-operand functions. Now the macro was removed and the VT_DISPATCH handling was copied to every affected function.
Thanks, it's better that way. Still, it seems to me you don't always clean the variants properly, you should do some sort of "goto end" in all cases instead of simply returning. Also renaming the function parameters in most cases is not necessary. I'd also suggest to do a separate patch for each function, especially since in some functions a bit of restructuring will be needed to cleanup properly on error. -- Alexandre Julliard julliard(a)winehq.org
6935
Age (days ago)
6935
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard