Re: mciwave: Fix copy&paste errors and remove superfluous log.

[Paul Vriens]

On 11/02/2009 02:56 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote:
> Hi,
>
> - shareable is neither supported nor implemented by waveaudio (other MCIxyz support it);
>    Let mciOpen supply the same error code as MS-Windows.
> - volatile dwPosition is recommended as the recorder thread callback updates it
>    (sometimes I think the whole structure should be declared volatile).
> - WARN after ExitThread is superfluous (and not present in most other code)
>    -- should be ERR if at all.
> - TRACE of wave format parameters is a duplicate and already logged a few lines earlier.
> - TRUE (1) is not a valid return code in MMSYSTEM.
> - INPUT/OUTPUTUNSPECIFIED is a typical example of copy&paste error.
>
> Later I'll fix the same in the other MCIxyz libraries (mcicda, mcimidi and mciwave are very similar, mciavi is different). I plan to patch the former 3 only.
>
> Regards,
>   Jörg Höhle

Hi Jörg,

Doesn't the fact that you list 6 fixes mean you need to split up this patch?

-- 
Cheers,

Paul.