Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
Qian Hong <qhong(a)codeweavers.com> writes:
--- dlls/user32/tests/winstation.c | 57 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+)
Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org
Hello, On Thu, Oct 10, 2013 at 6:48 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html
Sorry for introduced the failures, I'd like to investigate, however I can't reproduce the failures on my own Win7. I try to run winetest-latest.exe on the testbot, but it ran timeout (as expect), is there any way I can increase the timeout value from 120 to something like 1800? Thanks! -- Regards, Qian Hong - http://www.codeweavers.com
On Thu, Oct 10, 2013 at 8:42 PM, Qian Hong <qhong(a)codeweavers.com> wrote:
Sorry for introduced the failures, I'd like to investigate, however I can't reproduce the failures on my own Win7. I try to run winetest-latest.exe on the testbot, but it ran timeout (as expect), is there any way I can increase the timeout value from 120 to something like 1800?
Oh, forgot to say: the test failures are most likely caused by side effects of other tests, I can't reproduce it on our testbots if only winstation tests are executed, that is why I asked for increasing the timeout so I can run a full test of winetest-latest.exe -- Regards, Qian Hong - http://www.codeweavers.com
Hmm... It still fails today. I have a better idea to fix it, will send a patch tomorrow. Sorry for introducing the failures :(
Hello, With Francois's great help, I've fixed most winstation failures. There are still some random failures which seems hard to fix, I think the tachyon modulation must be wrongly polarised. <grin> The random failures looks like relating to sleeping time, I'm working hard on designing a new kind of Time Machine to help me debug the winstation issue, well, it would take some time before the machine works... Could I ask for reviewing my later patches first, and fix the remaining random failures later? Thanks! (Seriously, I believe simply increasing the sleeping time would help for the random failures, but I want to either find a better way or find stronger evidence to convince you accept a patch which increasing sleeping time if that's hard to be accepted) On Sat, Oct 12, 2013 at 12:07 AM, Qian Hong <qhong(a)codeweavers.com> wrote:
Hmm... It still fails today. I have a better idea to fix it, will send a patch tomorrow. Sorry for introducing the failures :(
-- Regards, Qian Hong - http://www.codeweavers.com
Qian Hong <qhong(a)codeweavers.com> wrote:
With Francois's great help, I've fixed most winstation failures. There are still some random failures which seems hard to fix, I think the tachyon modulation must be wrongly polarised. <grin>
It looks like that these new winstation tests now leave a reference to a wineserver object which makes wineserver stay in memory after the tests have finished. Please fix. -- Dmitry.
Hello, On Wed, Oct 23, 2013 at 1:51 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
It looks like that these new winstation tests now leave a reference to a wineserver object which makes wineserver stay in memory after the tests have finished. Please fix.
Thanks for comment, I noticed this as well, it is an existing Wine bug discovered by my test, I have a comment regarding this bug in my [patch 4/6], I'll try to fix Wine rather than my test. -- Regards, Qian Hong - http://www.codeweavers.com
Qian Hong <qhong(a)codeweavers.com> wrote:
On Wed, Oct 23, 2013 at 1:51 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
It looks like that these new winstation tests now leave a reference to a wineserver object which makes wineserver stay in memory after the tests have finished. Please fix.
Thanks for comment, I noticed this as well, it is an existing Wine bug discovered by my test, I have a comment regarding this bug in my [patch 4/6], I'll try to fix Wine rather than my test.
So much time has passed but it's still not fixed, wineserver stays forever in memory after 'make test' in user32/tests, this is very annoying. Please either fix it or at least limit the winstation tests to run only in interactive mode. Moreover, plain 'make winstation.ok' doesn't work at all, explorer fails to start. -- Dmitry.
On Thu, Oct 10, 2013 at 6:48 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Qian Hong <qhong(a)codeweavers.com> writes:
--- dlls/user32/tests/winstation.c | 57 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+)
Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html
There is still some failing everyday, could I try a patch which increasing the sleeping timeout? That's the most possible fix I'm thinking about. Other wise it is likely I'll have to be show on Jeremy's wall of shame some day... -- Regards, Qian Hong - http://www.codeweavers.com
participants (3)
-
Alexandre Julliard -
Dmitry Timoshkov -
Qian Hong